WIP: refactory cpp metric #914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/taiye/add_metric
yyuuttaaoo
requested changes
Jun 16, 2023
|
|
||
| std::atomic_long timestamp; | ||
| }; | ||
| public: |
| @@ -222,6 +227,14 @@ func GetContainerMeta(containerID string) *C.struct_containerMeta { | |||
| return returnStruct | |||
| } | |||
|
|
|||
| //export GetPipelineMetrics | |||
| func GetPipelineMetrics(piplineID string) *C.struct_pipelineMetric { | |||
There was a problem hiding this comment.
后面go这边可能是一把把所有metric都返回吧
|
|
||
| void ILogtailMetric::deletePipelineMetric(PipelineMetricPtr pipelineMetric) { | ||
| std::lock_guard<std::mutex> lock(mMetricsLock); | ||
| mPipelineMetrics.remove(pipelineMetric); |
There was a problem hiding this comment.
这是O(n)的，我感觉要O(1)删的话，可能得自己实现双向链表并持有其Node，而非val
| BaseMetric(); | ||
| BaseMetric(MetricObj* metricObj); | ||
| ~BaseMetric(); | ||
| MetricObj* mMetricObj; |
| class PipelineMetric { | ||
| public: | ||
| std::unordered_map<std::string, BaseMetricPtr> mBaseMetrics; | ||
| std::unordered_map<std::string, std::string> mLabels; |
There was a problem hiding this comment.
有没有必要使用map？这个数据是不是第一次创建后就不变的？也没有查的需求
|
|
||
| class PipelineMetric { | ||
| public: | ||
| std::unordered_map<std::string, BaseMetricPtr> mBaseMetrics; |
| return; | ||
| } | ||
| mSnapshotPipelineMetrics.clear(); | ||
| std::lock_guard<std::mutex> lock(ILogtailMetric::GetInstance()->mMetricsLock); |
| @@ -81,7 +81,7 @@ include(${CMAKE_CURRENT_SOURCE_DIR}/dependencies.cmake) | |||
| # Subdirectories (modules). | |||
| set(SUB_DIRECTORIES_LIST | |||
| aggregator app_config checkpoint common config config_manager config_server_pb | |||
| controller event event_handler event_listener helper log_pb logger monitor | |||
| controller event event_handler event_listener helper log_pb logger monitor ilogtail_metric | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.