Features/refactor #110
Merged
Features/refactor #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzwlqx
force-pushed
the
features/refactor
branch
2 times, most recently
from
ce83edb
to
59db0a5
Compare
1. Now metrics probe is free to add any prometheus metrics
2. Arguments is allowed when config probes
3. Flexible configuration of event storage
4. More structured metrics names, use kubeskoop_{module}_metrics instead of inspector_pod{module}{metrics}
5. Change log lib from slog to logrus
jzwlqx
force-pushed
the
features/refactor
branch
from
08fc7ce
to
35411a6
Compare
BSWANG
reviewed
Sep 25, 2023
BSWANG
approved these changes
Sep 26, 2023
Lyt99
requested changes
Sep 28, 2023
| interval: 15 | ||
| port: 9102 | ||
| port: 9102 | ||
| metrics: | ||
| probes: |
There was a problem hiding this comment.
helm chart also needs to be changed
Lyt99
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A huge commit with many changes
kubeskoop_{module}_metricsinstead ofinspector_pod_{module}{metrics}