polish

alibaba · Nov 13, 2024 · f09604d · f09604d
1 parent c0e1583
commit f09604d
Show file tree

Hide file tree

Showing 30 changed files with 92 additions and 93 deletions.
diff --git a/core/common/compression/Compressor.cpp b/core/common/compression/Compressor.cpp
@@ -23,7 +23,7 @@ using namespace std;
 namespace logtail {
 
 void Compressor::SetMetricRecordRef(MetricLabels&& labels, DynamicMetricLabels&& dynamicLabels) {
-    MetricManager::GetInstance()->PrepareMetricsRecordRef(
+    WriteMetrics::GetInstance()->PrepareMetricsRecordRef(
         mMetricsRecordRef, MetricCategory::METRIC_CATEGORY_COMPONENT, std::move(labels), std::move(dynamicLabels));
     mInItemsTotal = mMetricsRecordRef.CreateCounter(METRIC_COMPONENT_IN_ITEMS_TOTAL);
     mInItemSizeBytes = mMetricsRecordRef.CreateCounter(METRIC_COMPONENT_IN_SIZE_BYTES);

diff --git a/core/ebpf/eBPFServer.cpp b/core/ebpf/eBPFServer.cpp
@@ -151,7 +151,7 @@ void eBPFServer::Init() {
     mMonitorMgr = std::make_unique<eBPFSelfMonitorMgr>();
     DynamicMetricLabels dynamicLabels;
     dynamicLabels.emplace_back(METRIC_LABEL_KEY_PROJECT, [this]() -> std::string { return this->GetAllProjects(); });
-    MetricManager::GetInstance()->PrepareMetricsRecordRef(mRef,
+    WriteMetrics::GetInstance()->PrepareMetricsRecordRef(mRef,
                                             MetricCategory::METRIC_CATEGORY_RUNNER,
                                             {{METRIC_LABEL_KEY_RUNNER_NAME, METRIC_LABEL_VALUE_RUNNER_NAME_EBPF_SERVER}}, 
                                             std::move(dynamicLabels));

diff --git a/core/file_server/FileServer.cpp b/core/file_server/FileServer.cpp
@@ -32,7 +32,7 @@ using namespace std;
 namespace logtail {
 
 FileServer::FileServer() {
-    MetricManager::GetInstance()->PrepareMetricsRecordRef(
+    WriteMetrics::GetInstance()->PrepareMetricsRecordRef(
         mMetricsRecordRef,
         MetricCategory::METRIC_CATEGORY_RUNNER,
         {{METRIC_LABEL_KEY_RUNNER_NAME, METRIC_LABEL_VALUE_RUNNER_NAME_FILE_SERVER}});

diff --git a/core/monitor/MetricExportor.cpp b/core/monitor/MetricExportor.cpp
@@ -51,7 +51,7 @@ void MetricExportor::PushMetrics(bool forceSend) {
     }
 
     // go指标在Cpp指标前获取，是为了在 Cpp 部分指标做 SnapShot
-    // 前（即调用 MetricManagerReader::GetInstance()->UpdateMetrics() 函数），把go部分的进程级指标填写到 Cpp
+    // 前（即调用 ReadMetrics::GetInstance()->UpdateMetrics() 函数），把go部分的进程级指标填写到 Cpp
     // 的进程级指标中去，随Cpp的进程级指标一起输出
     if (LogtailPlugin::GetInstance()->IsPluginOpened()) {
         PushGoMetrics();
@@ -60,15 +60,15 @@ void MetricExportor::PushMetrics(bool forceSend) {
 }
 
 void MetricExportor::PushCppMetrics() {
-    MetricManagerReader::GetInstance()->UpdateMetrics();
+    ReadMetrics::GetInstance()->UpdateMetrics();
 
     if ("sls" == STRING_FLAG(metrics_report_method)) {
         std::map<std::string, sls_logs::LogGroup*> logGroupMap;
-        MetricManagerReader::GetInstance()->ReadAsLogGroup(METRIC_LABEL_KEY_REGION, METRIC_REGION_DEFAULT, logGroupMap);
+        ReadMetrics::GetInstance()->ReadAsLogGroup(METRIC_LABEL_KEY_REGION, METRIC_REGION_DEFAULT, logGroupMap);
         SendToSLS(logGroupMap);
     } else if ("file" == STRING_FLAG(metrics_report_method)) {
         std::string metricsContent;
-        MetricManagerReader::GetInstance()->ReadAsFileBuffer(metricsContent);
+        ReadMetrics::GetInstance()->ReadAsFileBuffer(metricsContent);
         SendToLocalFile(metricsContent, "self-metrics-cpp");
     }
 }

diff --git a/core/monitor/MetricManager.cpp b/core/monitor/MetricManager.cpp
@@ -24,19 +24,19 @@ using namespace sls_logs;
 
 namespace logtail {
 
-MetricManager::~MetricManager() {
+WriteMetrics::~WriteMetrics() {
     Clear();
 }
 
-void MetricManager::PrepareMetricsRecordRef(MetricsRecordRef& ref,
+void WriteMetrics::PrepareMetricsRecordRef(MetricsRecordRef& ref,
                                            const std::string& category,
                                            MetricLabels&& labels,
                                            DynamicMetricLabels&& dynamicLabels) {
     CreateMetricsRecordRef(ref, category, std::move(labels), std::move(dynamicLabels));
     CommitMetricsRecordRef(ref);
 }
 
-void MetricManager::CreateMetricsRecordRef(MetricsRecordRef& ref,
+void WriteMetrics::CreateMetricsRecordRef(MetricsRecordRef& ref,
                                           const std::string& category,
                                           MetricLabels&& labels,
                                           DynamicMetricLabels&& dynamicLabels) {
@@ -45,18 +45,18 @@ void MetricManager::CreateMetricsRecordRef(MetricsRecordRef& ref,
     ref.SetMetricsRecord(cur);
 }
 
-void MetricManager::CommitMetricsRecordRef(MetricsRecordRef& ref) {
+void WriteMetrics::CommitMetricsRecordRef(MetricsRecordRef& ref) {
     std::lock_guard<std::mutex> lock(mMutex);
     ref.mMetrics->SetNext(mHead);
     mHead = ref.mMetrics;
 }
 
-MetricsRecord* MetricManager::GetHead() {
+MetricsRecord* WriteMetrics::GetHead() {
     std::lock_guard<std::mutex> lock(mMutex);
     return mHead;
 }
 
-void MetricManager::Clear() {
+void WriteMetrics::Clear() {
     std::lock_guard<std::mutex> lock(mMutex);
     while (mHead) {
         MetricsRecord* toDeleted = mHead;
@@ -65,7 +65,7 @@ void MetricManager::Clear() {
     }
 }
 
-MetricsRecord* MetricManager::DoSnapshot() {
+MetricsRecord* WriteMetrics::DoSnapshot() {
     // new read head
     MetricsRecord* snapshot = nullptr;
     MetricsRecord* toDeleteHead = nullptr;
@@ -146,11 +146,11 @@ MetricsRecord* MetricManager::DoSnapshot() {
     return snapshot;
 }
 
-MetricManagerReader::~MetricManagerReader() {
+ReadMetrics::~ReadMetrics() {
     Clear();
 }
 
-void MetricManagerReader::ReadAsLogGroup(const std::string& regionFieldName,
+void ReadMetrics::ReadAsLogGroup(const std::string& regionFieldName,
                                  const std::string& defaultRegion,
                                  std::map<std::string, sls_logs::LogGroup*>& logGroupMap) const {
     ReadLock lock(mReadWriteLock);
@@ -241,7 +241,7 @@ void MetricManagerReader::ReadAsLogGroup(const std::string& regionFieldName,
     }
 }
 
-void MetricManagerReader::ReadAsFileBuffer(std::string& metricsContent) const {
+void ReadMetrics::ReadAsFileBuffer(std::string& metricsContent) const {
     ReadLock lock(mReadWriteLock);
 
     std::ostringstream oss;
@@ -292,8 +292,8 @@ void MetricManagerReader::ReadAsFileBuffer(std::string& metricsContent) const {
     metricsContent = oss.str();
 }
 
-void MetricManagerReader::UpdateMetrics() {
-    MetricsRecord* snapshot = MetricManager::GetInstance()->DoSnapshot();
+void ReadMetrics::UpdateMetrics() {
+    MetricsRecord* snapshot = WriteMetrics::GetInstance()->DoSnapshot();
     MetricsRecord* toDelete;
     {
         // Only lock when change head
@@ -309,12 +309,12 @@ void MetricManagerReader::UpdateMetrics() {
     }
 }
 
-MetricsRecord* MetricManagerReader::GetHead() {
+MetricsRecord* ReadMetrics::GetHead() {
     WriteLock lock(mReadWriteLock);
     return mHead;
 }
 
-void MetricManagerReader::Clear() {
+void ReadMetrics::Clear() {
     WriteLock lock(mReadWriteLock);
     while (mHead) {
         MetricsRecord* toDelete = mHead;

diff --git a/core/monitor/MetricManager.h b/core/monitor/MetricManager.h
@@ -28,19 +28,19 @@
 
 namespace logtail {
 
-class MetricManager {
+class WriteMetrics {
 private:
-    MetricManager() = default;
+    WriteMetrics() = default;
     std::mutex mMutex;
     MetricsRecord* mHead = nullptr;
 
     void Clear();
     MetricsRecord* GetHead();
 
 public:
-    ~MetricManager();
-    static MetricManager* GetInstance() {
-        static MetricManager* ptr = new MetricManager();
+    ~WriteMetrics();
+    static WriteMetrics* GetInstance() {
+        static WriteMetrics* ptr = new WriteMetrics();
         return ptr;
     }
 
@@ -61,18 +61,18 @@ class MetricManager {
 #endif
 };
 
-class MetricManagerReader {
+class ReadMetrics {
 private:
-    MetricManagerReader() = default;
+    ReadMetrics() = default;
     mutable ReadWriteLock mReadWriteLock;
     MetricsRecord* mHead = nullptr;
     void Clear();
     MetricsRecord* GetHead();
 
 public:
-    ~MetricManagerReader();
-    static MetricManagerReader* GetInstance() {
-        static MetricManagerReader* ptr = new MetricManagerReader();
+    ~ReadMetrics();
+    static ReadMetrics* GetInstance() {
+        static ReadMetrics* ptr = new ReadMetrics();
         return ptr;
     }
     void ReadAsLogGroup(const std::string& regionFieldName,

diff --git a/core/monitor/MetricRecord.h b/core/monitor/MetricRecord.h
@@ -68,7 +68,7 @@ class MetricsRecord {
 };
 
 class MetricsRecordRef {
-    friend class MetricManager;
+    friend class WriteMetrics;
     friend bool operator==(const MetricsRecordRef& lhs, std::nullptr_t rhs);
     friend bool operator==(std::nullptr_t rhs, const MetricsRecordRef& lhs);
 
@@ -91,7 +91,7 @@ class MetricsRecordRef {
     IntGaugePtr CreateIntGauge(const std::string& name);
     DoubleGaugePtr CreateDoubleGauge(const std::string& name);
     const MetricsRecord* operator->() const;
-    // this is not thread-safe, and should be only used before MetricManager::CommitMetricsRecordRef
+    // this is not thread-safe, and should be only used before WriteMetrics::CommitMetricsRecordRef
     void AddLabels(MetricLabels&& labels);
 #ifdef APSARA_UNIT_TEST_MAIN
     bool HasLabel(const std::string& key, const std::string& value) const;

diff --git a/core/monitor/Monitor.cpp b/core/monitor/Monitor.cpp
@@ -708,7 +708,7 @@ void LoongCollectorMonitor::Init() {
         return EnterpriseConfigProvider::GetInstance()->GetUserDefinedIdSet();
     });
 #endif
-    MetricManager::GetInstance()->PrepareMetricsRecordRef(
+    WriteMetrics::GetInstance()->PrepareMetricsRecordRef(
         mMetricsRecordRef, MetricCategory::METRIC_CATEGORY_AGENT, std::move(labels), std::move(dynamicLabels));
     // init value
     mAgentCpu = mMetricsRecordRef.CreateDoubleGauge(METRIC_AGENT_CPU);

diff --git a/core/monitor/PluginMetricManager.cpp b/core/monitor/PluginMetricManager.cpp
@@ -22,7 +22,7 @@ void ReentrantMetricsRecord::Init(const std::string& category,
                                   MetricLabels& labels,
                                   DynamicMetricLabels& dynamicLabels,
                                   std::unordered_map<std::string, MetricType>& metricKeys) {
-    MetricManager::GetInstance()->PrepareMetricsRecordRef(
+    WriteMetrics::GetInstance()->PrepareMetricsRecordRef(
         mMetricsRecordRef, category, std::move(labels), std::move(dynamicLabels));
     for (auto metric : metricKeys) {
         switch (metric.second) {

diff --git a/core/pipeline/Pipeline.cpp b/core/pipeline/Pipeline.cpp
@@ -316,7 +316,7 @@ bool Pipeline::Init(PipelineConfig&& config) {
         ProcessQueueManager::GetInstance()->SetDownStreamQueues(mContext.GetProcessQueueKey(), std::move(senderQueues));
     }
 
-    MetricManager::GetInstance()->PrepareMetricsRecordRef(
+    WriteMetrics::GetInstance()->PrepareMetricsRecordRef(
         mMetricsRecordRef,
         MetricCategory::METRIC_CATEGORY_PIPELINE,
         {{METRIC_LABEL_KEY_PROJECT, mContext.GetProjectName()}, {METRIC_LABEL_KEY_PIPELINE_NAME, mName}});

diff --git a/core/pipeline/batch/Batcher.h b/core/pipeline/batch/Batcher.h
@@ -110,7 +110,7 @@ class Batcher {
         } else {
             labels.emplace_back(METRIC_LABEL_KEY_GROUP_BATCH_ENABLED, "false");
         }
-        MetricManager::GetInstance()->PrepareMetricsRecordRef(
+        WriteMetrics::GetInstance()->PrepareMetricsRecordRef(
             mMetricsRecordRef, MetricCategory::METRIC_CATEGORY_COMPONENT, std::move(labels));
         mInEventsTotal = mMetricsRecordRef.CreateCounter(METRIC_COMPONENT_IN_EVENTS_TOTAL);
         mInGroupDataSizeBytes = mMetricsRecordRef.CreateCounter(METRIC_COMPONENT_IN_SIZE_BYTES);

diff --git a/core/pipeline/plugin/interface/Plugin.h b/core/pipeline/plugin/interface/Plugin.h
@@ -37,7 +37,7 @@ class Plugin {
     void SetContext(PipelineContext& context) { mContext = &context; }
     MetricsRecordRef& GetMetricsRecordRef() const { return mMetricsRecordRef; }
     void SetMetricsRecordRef(const std::string& name, const std::string& id) {
-        MetricManager::GetInstance()->PrepareMetricsRecordRef(
+        WriteMetrics::GetInstance()->PrepareMetricsRecordRef(
             mMetricsRecordRef,
             MetricCategory::METRIC_CATEGORY_PLUGIN,
             {{METRIC_LABEL_KEY_PROJECT, mContext->GetProjectName()},

diff --git a/core/pipeline/queue/BoundedProcessQueue.cpp b/core/pipeline/queue/BoundedProcessQueue.cpp
@@ -28,7 +28,7 @@ BoundedProcessQueue::BoundedProcessQueue(
     if (ctx.IsExactlyOnceEnabled()) {
         mMetricsRecordRef.AddLabels({{METRIC_LABEL_KEY_EXACTLY_ONCE_ENABLED, "true"}});
     }
-    MetricManager::GetInstance()->CommitMetricsRecordRef(mMetricsRecordRef);
+    WriteMetrics::GetInstance()->CommitMetricsRecordRef(mMetricsRecordRef);
 }
 
 bool BoundedProcessQueue::Push(unique_ptr<ProcessQueueItem>&& item) {

diff --git a/core/pipeline/queue/CircularProcessQueue.cpp b/core/pipeline/queue/CircularProcessQueue.cpp
@@ -26,7 +26,7 @@ CircularProcessQueue::CircularProcessQueue(size_t cap, int64_t key, uint32_t pri
     : QueueInterface<std::unique_ptr<ProcessQueueItem>>(key, cap, ctx), ProcessQueueInterface(key, cap, priority, ctx) {
     mMetricsRecordRef.AddLabels({{METRIC_LABEL_KEY_QUEUE_TYPE, "circular"}});
     mDiscardedEventsTotal = mMetricsRecordRef.CreateCounter(METRIC_COMPONENT_QUEUE_DISCARDED_EVENTS_TOTAL);
-    MetricManager::GetInstance()->CommitMetricsRecordRef(mMetricsRecordRef);
+    WriteMetrics::GetInstance()->CommitMetricsRecordRef(mMetricsRecordRef);
 }
 
 bool CircularProcessQueue::Push(unique_ptr<ProcessQueueItem>&& item) {

diff --git a/core/pipeline/queue/ExactlyOnceSenderQueue.cpp b/core/pipeline/queue/ExactlyOnceSenderQueue.cpp
@@ -33,7 +33,7 @@ ExactlyOnceSenderQueue::ExactlyOnceSenderQueue(const std::vector<RangeCheckpoint
       mRangeCheckpoints(checkpoints) {
     mQueue.resize(checkpoints.size());
     mMetricsRecordRef.AddLabels({{METRIC_LABEL_KEY_EXACTLY_ONCE_ENABLED, "true"}});
-    MetricManager::GetInstance()->CommitMetricsRecordRef(mMetricsRecordRef);
+    WriteMetrics::GetInstance()->CommitMetricsRecordRef(mMetricsRecordRef);
 }
 
 bool ExactlyOnceSenderQueue::Push(unique_ptr<SenderQueueItem>&& item) {

diff --git a/core/pipeline/queue/QueueInterface.h b/core/pipeline/queue/QueueInterface.h
@@ -27,7 +27,7 @@ template <typename T>
 class QueueInterface {
 public:
     QueueInterface(QueueKey key, size_t cap, const PipelineContext& ctx) : mKey(key), mCapacity(cap) {
-        MetricManager::GetInstance()->CreateMetricsRecordRef(mMetricsRecordRef,
+        WriteMetrics::GetInstance()->CreateMetricsRecordRef(mMetricsRecordRef,
                                                             MetricCategory::METRIC_CATEGORY_COMPONENT,
                                                             {
                                                                 {METRIC_LABEL_KEY_PROJECT, ctx.GetProjectName()},

diff --git a/core/pipeline/queue/SenderQueue.cpp b/core/pipeline/queue/SenderQueue.cpp
@@ -27,7 +27,7 @@ SenderQueue::SenderQueue(
     mFetchTimesCnt = mMetricsRecordRef.CreateCounter(METRIC_COMPONENT_QUEUE_FETCH_TIMES_TOTAL);
     mValidFetchTimesCnt = mMetricsRecordRef.CreateCounter(METRIC_COMPONENT_QUEUE_VALID_FETCH_TIMES_TOTAL);
     mFetchedItemsCnt = mMetricsRecordRef.CreateCounter(METRIC_COMPONENT_QUEUE_FETCHED_ITEMS_TOTAL);
-    MetricManager::GetInstance()->CommitMetricsRecordRef(mMetricsRecordRef);
+    WriteMetrics::GetInstance()->CommitMetricsRecordRef(mMetricsRecordRef);
 }
 
 bool SenderQueue::Push(unique_ptr<SenderQueueItem>&& item) {

diff --git a/core/pipeline/route/Router.cpp b/core/pipeline/route/Router.cpp
@@ -35,7 +35,7 @@ bool Router::Init(std::vector<pair<size_t, const Json::Value*>> configs, const P
         }
     }
 
-    MetricManager::GetInstance()->PrepareMetricsRecordRef(
+    WriteMetrics::GetInstance()->PrepareMetricsRecordRef(
         mMetricsRecordRef,
         MetricCategory::METRIC_CATEGORY_COMPONENT,
         {{METRIC_LABEL_KEY_PROJECT, ctx.GetProjectName()},

diff --git a/core/pipeline/serializer/Serializer.h b/core/pipeline/serializer/Serializer.h
@@ -47,7 +47,7 @@ template <typename T>
 class Serializer {
 public:
     Serializer(Flusher* f) : mFlusher(f) {
-        MetricManager::GetInstance()->PrepareMetricsRecordRef(
+        WriteMetrics::GetInstance()->PrepareMetricsRecordRef(
             mMetricsRecordRef,
             MetricCategory::METRIC_CATEGORY_COMPONENT,
             {{METRIC_LABEL_KEY_PROJECT, f->GetContext().GetProjectName()},

diff --git a/core/prometheus/PrometheusInputRunner.cpp b/core/prometheus/PrometheusInputRunner.cpp
@@ -62,7 +62,7 @@ PrometheusInputRunner::PrometheusInputRunner()
     DynamicMetricLabels dynamicLabels;
     dynamicLabels.emplace_back(METRIC_LABEL_KEY_PROJECT, [this]() -> std::string { return this->GetAllProjects(); });
 
-    MetricManager::GetInstance()->PrepareMetricsRecordRef(
+    WriteMetrics::GetInstance()->PrepareMetricsRecordRef(
         mMetricsRecordRef, MetricCategory::METRIC_CATEGORY_RUNNER, std::move(labels), std::move(dynamicLabels));
 
     mPromRegisterState = mMetricsRecordRef.CreateIntGauge(METRIC_RUNNER_CLIENT_REGISTER_STATE);

diff --git a/core/prometheus/schedulers/ScrapeScheduler.cpp b/core/prometheus/schedulers/ScrapeScheduler.cpp
@@ -221,7 +221,7 @@ void ScrapeScheduler::InitSelfMonitor(const MetricLabels& defaultLabels) {
 
     mSelfMonitor->InitMetricManager(sScrapeMetricKeys, labels);
 
-    MetricManager::GetInstance()->PrepareMetricsRecordRef(mMetricsRecordRef, MetricCategory::METRIC_CATEGORY_PLUGIN_SOURCE, std::move(labels));
+    WriteMetrics::GetInstance()->PrepareMetricsRecordRef(mMetricsRecordRef, MetricCategory::METRIC_CATEGORY_PLUGIN_SOURCE, std::move(labels));
     mPromDelayTotal = mMetricsRecordRef.CreateCounter(METRIC_PLUGIN_PROM_SCRAPE_DELAY_TOTAL);
     mPluginTotalDelayMs = mMetricsRecordRef.CreateCounter(METRIC_PLUGIN_TOTAL_DELAY_MS);
 }

diff --git a/core/prometheus/schedulers/TargetSubscriberScheduler.cpp b/core/prometheus/schedulers/TargetSubscriberScheduler.cpp
@@ -334,7 +334,7 @@ void TargetSubscriberScheduler::InitSelfMonitor(const MetricLabels& defaultLabel
     mSelfMonitor = std::make_shared<PromSelfMonitorUnsafe>();
     mSelfMonitor->InitMetricManager(sSubscriberMetricKeys, mDefaultLabels);
 
-    MetricManager::GetInstance()->PrepareMetricsRecordRef(mMetricsRecordRef, MetricCategory::METRIC_CATEGORY_PLUGIN_SOURCE, std::move(mDefaultLabels));
+    WriteMetrics::GetInstance()->PrepareMetricsRecordRef(mMetricsRecordRef, MetricCategory::METRIC_CATEGORY_PLUGIN_SOURCE, std::move(mDefaultLabels));
     mPromSubscriberTargets = mMetricsRecordRef.CreateIntGauge(METRIC_PLUGIN_PROM_SUBSCRIBE_TARGETS);
     mTotalDelayMs = mMetricsRecordRef.CreateCounter(METRIC_PLUGIN_TOTAL_DELAY_MS);
 }

diff --git a/core/runner/FlusherRunner.cpp b/core/runner/FlusherRunner.cpp
@@ -43,7 +43,7 @@ bool FlusherRunner::Init() {
     mCallback = [this]() { return LoadModuleConfig(false); };
     AppConfig::GetInstance()->RegisterCallback("max_bytes_per_sec", &mCallback);
 
-    MetricManager::GetInstance()->PrepareMetricsRecordRef(
+    WriteMetrics::GetInstance()->PrepareMetricsRecordRef(
         mMetricsRecordRef,
         MetricCategory::METRIC_CATEGORY_RUNNER,
         {{METRIC_LABEL_KEY_RUNNER_NAME, METRIC_LABEL_VALUE_RUNNER_NAME_FLUSHER}});

diff --git a/core/runner/ProcessorRunner.cpp b/core/runner/ProcessorRunner.cpp
@@ -87,7 +87,7 @@ void ProcessorRunner::Run(uint32_t threadNo) {
     LOG_INFO(sLogger, ("processor runner", "started")("thread no", threadNo));
 
     // thread local metrics should be initialized in each thread
-    MetricManager::GetInstance()->PrepareMetricsRecordRef(
+    WriteMetrics::GetInstance()->PrepareMetricsRecordRef(
         sMetricsRecordRef,
         MetricCategory::METRIC_CATEGORY_RUNNER,
         {{METRIC_LABEL_KEY_RUNNER_NAME, METRIC_LABEL_VALUE_RUNNER_NAME_PROCESSOR},

diff --git a/core/runner/sink/http/HttpSink.cpp b/core/runner/sink/http/HttpSink.cpp
@@ -38,7 +38,7 @@ bool HttpSink::Init() {
         return false;
     }
 
-    MetricManager::GetInstance()->PrepareMetricsRecordRef(
+    WriteMetrics::GetInstance()->PrepareMetricsRecordRef(
         mMetricsRecordRef,
         MetricCategory::METRIC_CATEGORY_RUNNER,
         {{METRIC_LABEL_KEY_RUNNER_NAME, METRIC_LABEL_VALUE_RUNNER_NAME_HTTP_SINK}});

diff --git a/core/unittest/input/InputNetworkObserverUnittest.cpp b/core/unittest/input/InputNetworkObserverUnittest.cpp
@@ -152,7 +152,6 @@ void InputNetworkObserverUnittest::OnSuccessfulStart() {
     unique_ptr<InputNetworkObserver> input;
     Json::Value configJson, optionalGoPipeline;
     string configStr, errorMsg;
-    uint32_t pluginIdx = 0;
 
     configStr = R"(
         {