Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The plugin log name and checkpoint name support the logtail mode. #1901

Merged
merged 17 commits into from
Nov 20, 2024

Conversation

quzard
Copy link
Collaborator

@quzard quzard commented Nov 19, 2024

This pull request introduces several new methods and configurations to better manage plugin-specific settings in the AppConfig class and related components. The changes focus on adding flexibility for log names, version tags, and checkpoint file names based on the logtail_mode flag.

New Methods and Configurations:

Plugin Configuration Updates:

  • core/go_pipeline/LogtailPlugin.cpp: Updated the LogtailPlugin constructor to use the new methods for setting LoongcollectorPluginLogName, LoongcollectorVersionTag, and LoongcollectorCheckPointFile in the plugin configuration.
  • pkg/config/global_config.go: Added new fields for LoongcollectorPluginLogName, LoongcollectorVersionTag, and LoongcollectorCheckPointFile in the GlobalConfig struct and initialized them in newGlobalConfig(). [1] [2]

Log and Checkpoint Management:

Miscellaneous:

@quzard quzard changed the title fix logtail_plugin.LOG Plugin Log Name Supports logtail mode Nov 19, 2024
@quzard quzard changed the title Plugin Log Name Supports logtail mode The plugin log name and checkpoint name support the logtail mode. Nov 19, 2024
core/app_config/AppConfig.cpp Show resolved Hide resolved
#include "config/watcher/InstanceConfigWatcher.h"
#include "config/watcher/PipelineConfigWatcher.h"
Copy link
Collaborator

@messixukejia messixukejia Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

开源文档。说明下如何兼容模式安装

@quzard quzard merged commit 7342a22 into alibaba:main Nov 20, 2024
15 checks passed
@henryzhx8 henryzhx8 added the enhancement Feature enhancement label Nov 22, 2024
@henryzhx8 henryzhx8 added this to the v3.0 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants