Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is a bug in CheckDbHealthTask method #11498

Closed
Bo-Qiu opened this issue Dec 12, 2023 · 2 comments
Closed

There is a bug in CheckDbHealthTask method #11498

Bo-Qiu opened this issue Dec 12, 2023 · 2 comments
Labels
area/Config kind/research
Milestone
2.3.1

Comments

@Bo-Qiu
Copy link
Contributor

Bo-Qiu commented Dec 12, 2023

Describe the bug
There is a bug in CheckDbHealthTask method.
image
When config_info_beta is empty, the database health check always fails.

Expected behavior
When config_info_beta is empty, if the db is healthy, the health check is successful.

Actually behavior
When config_info_beta is empty, the database health check always fails.
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Dec 12, 2023
@Bo-Qiu
fix(alibaba#11498): fix CheckDbHealthTask.
c4b60d6
@Bo-Qiu Bo-Qiu mentioned this issue Dec 12, 2023
Merged
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Dec 12, 2023
@Bo-Qiu
fix(alibaba#11498): fix CheckDbHealthTask.
ae99ace
Bo-Qiu added a commit to Bo-Qiu/nacos that referenced this issue Dec 12, 2023
@Bo-Qiu
fix(alibaba#11498): fix CheckDbHealthTask.
d7f25dd
@KomachiSion KomachiSion added this to the 2.3.1 milestone Dec 15, 2023
shiyiyue1102 pushed a commit that referenced this issue Dec 28, 2023
@Bo-Qiu
fix(#11498): fix CheckDbHealthTask. (#11500)
526227c
@shiyiyue1102
Copy link
Collaborator

has been merge to develop branch ,close this issue

@superYuanC
Copy link

麻烦问下，这个bug，在哪个发行版本修复了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/Config kind/research
Projects
None yet
Milestone
2.3.1
Development

No branches or pull requests
4 participants
@shiyiyue1102 @KomachiSion @superYuanC @Bo-Qiu