-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #9085]Add the Reachability Metadata required by native-image #10634
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #10634 +/- ##
=============================================
- Coverage 53.62% 53.60% -0.03%
- Complexity 5504 5516 +12
=============================================
Files 897 897
Lines 28811 28811
Branches 3161 3161
=============================================
- Hits 15451 15443 -8
- Misses 12008 12019 +11
+ Partials 1352 1349 -3 see 21 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@@ -354,6 +354,13 @@ | |||
<exclude>src/main/java/com/alibaba/nacos/common/packagescan/classreading/**</exclude> | |||
<exclude>.flattened-pom.xml</exclude> | |||
<exclude>**/announcement.conf</exclude> | |||
<exclude>**/reflect-config.json</exclude> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add ignored by rat but not add copyright?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
native-image-agent: Error: cannot parse filter file C:\Users\Darren\IdeaProjects\nacos\client\filter-config.json: com.oracle.svm.core.util.json.JSONParserException: line 1 column 0 Expected json literal but found /
If the json file add copyright it will not work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
Add Reachability Metadata so that it can be compiled and successfully registered and configured with nacos-client when using springboot native-image, but the current method of getting Reachability Metadata is not very good. agent to achieve, but the coverage of unit tests is relatively low, resulting in some of the required content is not successfully obtained, so manually add part of the Reachability Metadata, the subsequent will write code to directly obtain this part of the data.
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.