Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9085]Add the Reachability Metadata required by native-image #10634

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

DarrenLuo
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Add Reachability Metadata so that it can be compiled and successfully registered and configured with nacos-client when using springboot native-image, but the current method of getting Reachability Metadata is not very good. agent to achieve, but the coverage of unit tests is relatively low, resulting in some of the required content is not successfully obtained, so manually add part of the Reachability Metadata, the subsequent will write code to directly obtain this part of the data.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023

Codecov Report

Merging #10634 (1f87b93) into develop (4de440d) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10634      +/-   ##
=============================================
- Coverage      53.62%   53.60%   -0.03%     
- Complexity      5504     5516      +12     
=============================================
  Files            897      897              
  Lines          28811    28811              
  Branches        3161     3161              
=============================================
- Hits           15451    15443       -8     
- Misses         12008    12019      +11     
+ Partials        1352     1349       -3     

see 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de440d...1f87b93. Read the comment docs.

@@ -354,6 +354,13 @@
<exclude>src/main/java/com/alibaba/nacos/common/packagescan/classreading/**</exclude>
<exclude>.flattened-pom.xml</exclude>
<exclude>**/announcement.conf</exclude>
<exclude>**/reflect-config.json</exclude>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add ignored by rat but not add copyright?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

native-image-agent: Error: cannot parse filter file C:\Users\Darren\IdeaProjects\nacos\client\filter-config.json: com.oracle.svm.core.util.json.JSONParserException: line 1 column 0 Expected json literal but found /

If the json file add copyright it will not work

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@KomachiSion KomachiSion merged commit f40e593 into alibaba:develop Jun 19, 2023
@KomachiSion KomachiSion linked an issue Jun 19, 2023 that may be closed by this pull request
@KomachiSion KomachiSion added this to the 2.3.0 milestone Jun 19, 2023
@KomachiSion KomachiSion added kind/feature type/feature area/Spring Boot Related to Spring Boot labels Jun 19, 2023
wukong121 pushed a commit to wukong121/nacos that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Spring Boot Related to Spring Boot kind/feature type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nacos不支持spring native
4 participants