Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #10374] Select clusters using the selector #10995

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

ldyedu
Copy link
Contributor

@ldyedu ldyedu commented Aug 20, 2023

What is the purpose of the change

For #10374, Select clusters using the selector

Brief changelog

  • nacos-api : Update NamingService.
  • nacos-client : Update NacosNamingService, InstancesChangeNotifier, ServiceInfoUpdateService and SelectorManager.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@ldyedu ldyedu closed this Aug 21, 2023
@ldyedu ldyedu reopened this Aug 23, 2023

private static final String DEFAULT_NAMING_LOG_FILE_PATH = "naming.log";


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change indent. Please use nacos code style to reformat

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@KomachiSion KomachiSion merged commit 4ad98d8 into alibaba:summer-ospp#10374 Sep 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants