Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix RaftConfig is always {} #11648

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

godhth
Copy link
Contributor

@godhth godhth commented Jan 12, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #11647

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.69%. Comparing base (a7d1c35) to head (07c3a96).
Report is 212 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #11648      +/-   ##
=============================================
- Coverage      66.75%   66.69%   -0.07%     
+ Complexity      8828     8822       -6     
=============================================
  Files           1237     1237              
  Lines          40615    40615              
  Branches        4322     4322              
=============================================
- Hits           27114    27087      -27     
- Misses         11539    11566      +27     
  Partials        1962     1962              
Files with missing lines Coverage Δ
...libaba/nacos/core/distributed/raft/RaftConfig.java 56.52% <100.00%> (+4.34%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d1c35...07c3a96. Read the comment docs.

@KomachiSion KomachiSion merged commit bdbc356 into alibaba:develop Jan 17, 2024
7 checks passed
@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Jan 17, 2024
@KomachiSion KomachiSion added this to the 2.3.1 milestone Jan 17, 2024
Bo-Qiu pushed a commit to Bo-Qiu/nacos that referenced this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The RaftConfig is always {}
3 participants