Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE#11957] No need init password when auth disabled. #12153

Merged
merged 1 commit into from
May 31, 2024
Merged

[ISSUE#11957] No need init password when auth disabled. #12153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...-auth-plugin/src/main/java/com/alibaba/nacos/plugin/auth/impl/NacosAuthPluginService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,16 @@ public boolean isLoginEnabled() {
return ApplicationUtils.getBean(AuthConfigs.class).isAuthEnabled();
}

/**
* Only auth enabled and not global admin role existed.
*
* @return {@code true} when auth enabled and not global admin role existed, otherwise {@code false}
*/
@Override
public boolean isAdminRequest() {
return !ApplicationUtils.getBean(IAuthenticationManager.class).hasGlobalAdminRole();
boolean authEnabled = ApplicationUtils.getBean(AuthConfigs.class).isAuthEnabled();
boolean hasGlobalAdminRole = ApplicationUtils.getBean(IAuthenticationManager.class).hasGlobalAdminRole();
return authEnabled && !hasGlobalAdminRole;
}

protected void checkNacosAuthManager() {
Expand Down
Loading