Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support aliyun ram v4 signature method. #12162

Merged

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added kind/feature type/feature area/Client Related to Nacos Client SDK labels May 31, 2024
@KomachiSion KomachiSion added this to the 2.4.0 milestone May 31, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 68.73%. Comparing base (857e611) to head (f3d66f2).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12162      +/-   ##
=============================================
+ Coverage      68.72%   68.73%   +0.01%     
- Complexity      9129     9140      +11     
=============================================
  Files           1252     1254       +2     
  Lines          40909    40952      +43     
  Branches        4341     4344       +3     
=============================================
+ Hits           28116    28150      +34     
- Misses         10778    10790      +12     
+ Partials        2015     2012       -3     
Files Coverage Δ
...n/java/com/alibaba/nacos/api/PropertyKeyConst.java 0.00% <ø> (ø)
...acos/client/auth/ram/RamClientAuthServiceImpl.java 100.00% <100.00%> (ø)
.../com/alibaba/nacos/client/auth/ram/RamContext.java 93.33% <100.00%> (+1.66%) ⬆️
...nt/auth/ram/injector/AbstractResourceInjector.java 100.00% <ø> (ø)
...ient/auth/ram/injector/ConfigResourceInjector.java 96.15% <100.00%> (+0.91%) ⬆️
...ient/auth/ram/injector/NamingResourceInjector.java 96.55% <100.00%> (+0.89%) ⬆️
...om/alibaba/nacos/client/auth/ram/RamConstants.java 0.00% <0.00%> (ø)
...ient/auth/ram/utils/CalculateV4SigningKeyUtil.java 87.50% <87.50%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 857e611...f3d66f2. Read the comment docs.

@KomachiSion KomachiSion merged commit 79a5aa5 into alibaba:develop May 31, 2024
7 checks passed
@KomachiSion KomachiSion deleted the develop-support-aliyun-v4-sign branch June 3, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK kind/feature type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants