Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #12146] 修复当对操作类型为删除的配置进行回滚时,操作类型不显示问题 #12164

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

misakacoder
Copy link
Contributor

@misakacoder misakacoder commented May 31, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #12146

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (04f9b86) to head (f3d5930).
Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #12164   +/-   ##
==========================================
  Coverage      68.74%   68.74%           
+ Complexity      9140     9138    -2     
==========================================
  Files           1254     1254           
  Lines          40952    40952           
  Branches        4344     4344           
==========================================
  Hits           28151    28151           
+ Misses         10787    10785    -2     
- Partials        2014     2016    +2     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f9b86...f3d5930. Read the comment docs.

@KomachiSion KomachiSion merged commit d1bd446 into alibaba:develop Jun 3, 2024
7 checks passed
@KomachiSion KomachiSion added this to the 2.4.0 milestone Jun 3, 2024
@KomachiSion KomachiSion added area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug. labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

配置回滚页面,操作类型不显示
3 participants