Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复mem计算逻辑 #12401

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

kangzhaok
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change
修复com.alibaba.nacos.sys.env.EnvUtil#getMem计算逻辑

Brief changelog
目前计算逻辑long/long,没有考虑小数问题

Verifying this change
本地测试且和1.x版本对比无误

关联issues #12374

@KomachiSion
Copy link
Collaborator

方便的话麻烦加一个单元测试

@kangzhaok
Copy link
Contributor Author

方便的话麻烦加一个单元测试

已添加

KomachiSion
KomachiSion previously approved these changes Jul 26, 2024
@KomachiSion
Copy link
Collaborator

CI can't pass

@KomachiSion KomachiSion merged commit 3967c91 into alibaba:develop Jul 31, 2024
7 checks passed
@KomachiSion KomachiSion added this to the 2.4.1 milestone Aug 15, 2024
@KomachiSion KomachiSion added the kind/bug Category issues or prs related to bug. label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants