-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor connection limit module to plugin #9653
Merged
KomachiSion
merged 51 commits into
alibaba:develop
from
shiyiyue1102:devolop_controlplugin_20221124_mergerdevelop
Dec 6, 2022
Merged
Refactor connection limit module to plugin #9653
KomachiSion
merged 51 commits into
alibaba:develop
from
shiyiyue1102:devolop_controlplugin_20221124_mergerdevelop
Dec 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lugin_20221124_mergerdevelop # Conflicts: # config/pom.xml # config/src/main/java/com/alibaba/nacos/config/server/controller/ConfigController.java # config/src/main/java/com/alibaba/nacos/config/server/service/LongPollingService.java # config/src/main/java/com/alibaba/nacos/config/server/service/datasource/ExternalDataSourceServiceImpl.java # core/src/main/java/com/alibaba/nacos/core/remote/control/TpsMonitorManager.java # plugin/pom.xml # pom.xml
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #9653 +/- ##
=============================================
- Coverage 47.62% 47.32% -0.31%
+ Complexity 4572 4480 -92
=============================================
Files 855 852 -3
Lines 28349 27781 -568
Branches 3197 3092 -105
=============================================
- Hits 13500 13146 -354
+ Misses 13609 13457 -152
+ Partials 1240 1178 -62
Continue to review full report at Codecov.
|
KomachiSion
changed the title
Devolop controlplugin 20221124 mergerdevelop
Refactor connection limit module to plugin
Dec 6, 2022
KomachiSion
approved these changes
Dec 6, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
反脆弱插件重构
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.