Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor connection limit module to plugin #9653

Conversation

shiyiyue1102
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

反脆弱插件重构

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

…lugin_20221124_mergerdevelop

# Conflicts:
#	config/pom.xml
#	config/src/main/java/com/alibaba/nacos/config/server/controller/ConfigController.java
#	config/src/main/java/com/alibaba/nacos/config/server/service/LongPollingService.java
#	config/src/main/java/com/alibaba/nacos/config/server/service/datasource/ExternalDataSourceServiceImpl.java
#	core/src/main/java/com/alibaba/nacos/core/remote/control/TpsMonitorManager.java
#	plugin/pom.xml
#	pom.xml
@codecov-commenter
Copy link

Codecov Report

Merging #9653 (ed74426) into develop (42ca5be) will decrease coverage by 0.30%.
The diff coverage is 38.68%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9653      +/-   ##
=============================================
- Coverage      47.62%   47.32%   -0.31%     
+ Complexity      4572     4480      -92     
=============================================
  Files            855      852       -3     
  Lines          28349    27781     -568     
  Branches        3197     3092     -105     
=============================================
- Hits           13500    13146     -354     
+ Misses         13609    13457     -152     
+ Partials        1240     1178      -62     
Impacted Files Coverage Δ
...om/alibaba/nacos/consistency/RequestProcessor.java 0.00% <ø> (ø)
...m/alibaba/nacos/core/control/TpsControlConfig.java 50.00% <ø> (ø)
...s/core/control/http/HttpTpsCheckRequestParser.java 0.00% <0.00%> (ø)
...ontrol/http/HttpTpsCheckRequestParserRegistry.java 0.00% <0.00%> (ø)
.../nacos/core/control/http/HttpTpsPointRegistry.java 0.00% <0.00%> (ø)
...e/control/http/NacosHttpTpsControlInterceptor.java 0.00% <0.00%> (ø)
...trol/http/NacosHttpTpsControlWebMvcConfigurer.java 0.00% <0.00%> (ø)
...re/control/remote/RemoteTpsCheckRequestParser.java 0.00% <0.00%> (ø)
...ol/remote/RemoteTpsCheckRequestParserRegistry.java 0.00% <0.00%> (ø)
...s/core/control/remote/TpsControlRequestFilter.java 0.00% <0.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42ca5be...ed74426. Read the comment docs.

@KomachiSion KomachiSion changed the title Devolop controlplugin 20221124 mergerdevelop Refactor connection limit module to plugin Dec 6, 2022
@KomachiSion KomachiSion added this to the 2.2.0 milestone Dec 6, 2022
@KomachiSion KomachiSion merged commit acc8ab4 into alibaba:develop Dec 6, 2022
@xingdong015 xingdong015 mentioned this pull request Jan 9, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants