Skip to content

Commit

Permalink
v0.115 remove unused suppressions
Browse files Browse the repository at this point in the history
Summary:
removed unused suppressions
```
~/fbsource/fbcode/flow/tool remove-comments --bin `which flow` ~/www
~/fbsource/fbcode/flow/tool remove-comments --bin `which flow` ~/www/html/js/mobile
~/fbsource/fbcode/flow/tool remove-comments --bin `which flow` ~/www/html/js/service_workers
~/fbsource/fbcode/flow/tool remove-comments --bin `which flow` ~/www/html/js/bladerunner
```
reverted generated files
```
hg status -n | xargs grep -P -l '@(partially-)?generated' | xargs hg revert -r .
```
prettified
```
hg status -n | xargs grep -l 'format' | xargs -P 20 -n 1000 prettier --write
```
reverted changes due to lingering Flow errors
```
html/js/bladerunner/lib/live_feed/fetch_experiment/GraphQLBatchRequest.js
html/shared/ads/types/AdsDraftPublishRealtimeTypes.js
html/shared/banzai/BanzaiLooper.js
html/shared/draft-js/component/base/DraftEditor.react.js
html/shared/modules/BigPipe.js
html/shared/modules/ReactRenderer.js
```

drop-conflicts

Reviewed By: dsainati1

Differential Revision: D19290448

fbshipit-source-id: cfdaefb8b5244483192e93d9edf8649a2900d2c5
  • Loading branch information
panagosg7 authored and facebook-github-bot committed Jan 7, 2020
1 parent eb12cfd commit ca00a95
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 19 deletions.
6 changes: 0 additions & 6 deletions src/component/base/DraftEditor.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -302,12 +302,6 @@ class DraftEditor extends React.Component<DraftEditorProps, State> {
accessibilityID: this._placeholderAccessibilityID,
};

/* $FlowFixMe(>=0.112.0 site=mobile) This comment suppresses an error
* found when Flow v0.112 was deployed. To see the error delete this
* comment and run Flow. */
/* $FlowFixMe(>=0.112.0 site=www) This comment suppresses an error found
* when Flow v0.112 was deployed. To see the error delete this comment
* and run Flow. */
/* $FlowFixMe(>=0.112.0 site=www,mobile) This comment suppresses an error
* found when Flow v0.112 was deployed. To see the error delete this
* comment and run Flow. */
Expand Down
6 changes: 0 additions & 6 deletions src/component/contents/DraftEditorContents-core.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -224,12 +224,6 @@ class DraftEditorContents extends React.Component<Props> {
const child = React.createElement(
Element,
childProps,
/* $FlowFixMe(>=0.112.0 site=mobile) This comment suppresses an error
* found when Flow v0.112 was deployed. To see the error delete this
* comment and run Flow. */
/* $FlowFixMe(>=0.112.0 site=www) This comment suppresses an error
* found when Flow v0.112 was deployed. To see the error delete this
* comment and run Flow. */
/* $FlowFixMe(>=0.112.0 site=www,mobile) This comment suppresses an
* error found when Flow v0.112 was deployed. To see the error delete
* this comment and run Flow. */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,6 @@ class DraftEditorContentsExperimental extends React.Component<Props> {
blockRenderMap.get('unstyled');
const wrapperTemplate = configForType.wrapper;
processedBlocks.push({
/* $FlowFixMe(>=0.112.0 site=mobile) This comment suppresses an error
* found when Flow v0.112 was deployed. To see the error delete this
* comment and run Flow. */
/* $FlowFixMe(>=0.112.0 site=www) This comment suppresses an error
* found when Flow v0.112 was deployed. To see the error delete this
* comment and run Flow. */
/* $FlowFixMe(>=0.112.0 site=www,mobile) This comment suppresses an
* error found when Flow v0.112 was deployed. To see the error delete
* this comment and run Flow. */
Expand Down
1 change: 0 additions & 1 deletion src/component/utils/isInstanceOfNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ function isInstanceOfNode(target: ?EventTarget): boolean {
if (!node.ownerDocument.defaultView) {
return node instanceof Node;
}
// $FlowFixMe https://github.com/DefinitelyTyped/DefinitelyTyped/issues/11508#issuecomment-256045682
if (node instanceof node.ownerDocument.defaultView.Node) {
return true;
}
Expand Down

0 comments on commit ca00a95

Please sign in to comment.