[camera] refactorize and clean up code #1515

mugulmd · 2023-08-23T11:55:56Z

Description

Refactorize and clean up code in the aliceVision_camera library.

rename some classes to improve coherence
avoid duplicating the Distortion class hierarchy into the Intrinsic class hierarchy
more flexible factory functions for intrinsics

mugulmd added 3 commits August 22, 2023 11:13

[camera] rename Intrinsics to Intrinsic in class names

ba96f2d

[camera] rename EquiDistant to Equidistant

ae6689e

[camera] remove distortion init mode from constructors

1b40559

mugulmd added the refactoring label Aug 23, 2023

mugulmd added this to the 3.2.0 milestone Aug 23, 2023

mugulmd requested review from fabiencastan and cbentejac August 23, 2023 11:55

mugulmd self-assigned this Aug 23, 2023

[camera] simplify intrinsic class hierarchy

a434e92

mugulmd force-pushed the mug/cameraCleanup branch 2 times, most recently from a898a90 to cf3b5e1 Compare August 24, 2023 12:20

mugulmd mentioned this pull request Aug 24, 2023

Update following changes in aliceVision_camera alicevision/QtAliceVision#40

Merged

[camera] more flexible factory functions for initializing cameras

0b808e4

mugulmd force-pushed the mug/cameraCleanup branch 3 times, most recently from c59dc94 to 2b01621 Compare August 24, 2023 14:49

[camera] use createPinhole and createEquidistant whenever possible

62fe7ea

mugulmd force-pushed the mug/cameraCleanup branch from 2b01621 to 62fe7ea Compare August 24, 2023 14:53

mugulmd marked this pull request as ready for review August 24, 2023 15:34

cbentejac approved these changes Aug 25, 2023

View reviewed changes

cbentejac merged commit 4b8d051 into develop Aug 25, 2023
3 of 4 checks passed

cbentejac deleted the mug/cameraCleanup branch August 25, 2023 14:53