Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sfmDataIO] getViewIntrinsics corrections #1522

Merged
merged 2 commits into from
Sep 4, 2023
Merged

[sfmDataIO] getViewIntrinsics corrections #1522

merged 2 commits into from
Sep 4, 2023

Conversation

mugulmd
Copy link
Contributor

@mugulmd mugulmd commented Aug 30, 2023 •
edited
Loading

Features list

  • avoid segmentation fault by adding safety check
  • remove duplicated function

@mugulmd mugulmd added the bugfix label Aug 30, 2023
@mugulmd mugulmd added this to the 3.2.0 milestone Aug 30, 2023
@mugulmd mugulmd self-assigned this Aug 30, 2023
@cbentejac cbentejac merged commit 7ed8ce5 into develop Sep 4, 2023
3 of 4 checks passed
@cbentejac cbentejac deleted the mug/fixViewIO branch September 4, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbentejac cbentejac cbentejac approved these changes

@demoulinv demoulinv demoulinv approved these changes

@fabiencastan fabiencastan Awaiting requested review from fabiencastan

Assignees

@mugulmd mugulmd

Labels
bugfix
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mugulmd @cbentejac @demoulinv