feat: client support credentialsProvider #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shabicheng
reviewed
Aug 29, 2023
| if now >= t.expirationInMills { | ||
| return true | ||
| } | ||
| duration := (float64)(t.expirationInMills-t.lastUpdatedInMills) * t.expiredFactor |
There was a problem hiding this comment.
即使 < 0 也没关系，一样会return true
There was a problem hiding this comment.
这里主要是担心客户端时间不严格有序
shabicheng
reviewed
Aug 29, 2023
credentials_provider.go
Outdated
| @@ -166,116 +174,16 @@ func (adp *UpdateFuncProviderAdapter) GetCredentials() (Credentials, error) { | |||
| // Returns true if no credentials ever fetched or credentials expired, | |||
| // or credentials will be expired soon | |||
| func (adp *UpdateFuncProviderAdapter) shouldRefresh() bool { | |||
| adp.mutex.RLock() | |||
There was a problem hiding this comment.
不要用mutex，和atomic相比性能相差几十、上百倍，参考：https://github.com/uber-go/atomic
credentials_provider.go
Outdated
| return accessKeyID != "" && accessKeySecret != "" && expirationTime.UnixMilli() > 0 | ||
| } | ||
|
|
||
| const ECS_RAM_ROLE_URL_PREFIX = "http://100.100.100.200/latest/meta-data/ram/security-credentials/" |
There was a problem hiding this comment.
我的意思并不是直接不要ECS RAM ROLE的功能，而是没必要再写一次冗余的ECS..Provider代码，其他的还是可以留着
producer/producer_config.go
Outdated
| NoRetryStatusCodeList []int | ||
| StsTokenShutDown chan struct{} |
There was a problem hiding this comment.
StsTokenShutDown 也要挪下来
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.