fix some bugs (#414)

aliyun · Oct 30, 2023 · 85d6790 · 85d6790
1 parent cf6ec90
commit 85d6790
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/oss/error.go b/oss/error.go
@@ -3,7 +3,7 @@ package oss
 import (
 	"encoding/xml"
 	"fmt"
-	"io"
+	"io/ioutil"
 	"net/http"
 	"strconv"
 	"strings"
@@ -78,7 +78,7 @@ func CheckCallbackResp(resp *Response) error {
 	contentLength, _ := strconv.Atoi(contentLengthStr)
 	var bodyBytes []byte
 	if contentLength > 0 {
-		bodyBytes, _ = io.ReadAll(resp.Body)
+		bodyBytes, _ = ioutil.ReadAll(resp.Body)
 	}
 	if len(bodyBytes) > 0 {
 		srvErr, errIn := serviceErrFromXML(bodyBytes, resp.StatusCode,

diff --git a/oss/option.go b/oss/option.go
@@ -3,7 +3,6 @@ package oss
 import (
 	"context"
 	"fmt"
-	"io"
 	"io/ioutil"
 	"net/http"
 	"net/url"
@@ -715,8 +714,6 @@ func GetCallbackBody(options []Option, resp *Response, callbackSet bool) error {
 		callback, _ := FindOption(options, HTTPHeaderOssCallback, nil)
 		if callback != nil {
 			err = setBody(options, resp)
-		}else{
-			io.Copy(io.Discard, resp.Body)
 		}
 	}
 	return err

diff --git a/sample/describe_regions.go b/sample/describe_regions.go
@@ -15,7 +15,7 @@ func DescribeRegionsSample() {
 
 	// Get describe regions
 	regionEndpoint := "oss-cn-hangzhou"
-	list, err := client.DescribeRegions(regionEndpoint)
+	list, err := client.DescribeRegions(oss.AddParam("regions", regionEndpoint))
 	if err != nil {
 		HandleError(err)
 	}
@@ -29,7 +29,7 @@ func DescribeRegionsSample() {
 
 	// List describe regions
 
-	list, err = client.DescribeRegions("")
+	list, err = client.DescribeRegions()
 	if err != nil {
 		HandleError(err)
 	}