Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot add new contributions #209

Closed
dexpota opened this issue Oct 7, 2019 · 8 comments
Closed

Cannot add new contributions #209

dexpota opened this issue Oct 7, 2019 · 8 comments
Labels
bug status: available

Comments

@dexpota
Copy link
Contributor

dexpota commented Oct 7, 2019

  • all-contributors-cli version: 6.9.1
  • node version: 12.6.0
  • npm version: 6.11.3

You can find the configuration file here

If I run all-contributors from the project's root directory and select to add a new contribution I get this error:

is/are invalid contribution type(s)

This issue is not present if I run all-contributors version 6.9.0
@Berkmann18
Copy link
Member

@dexpota What exactly have you typed?

@dexpota
Copy link
Contributor Author

dexpota commented Oct 7, 2019

I typed all-contributors on the shell then I selected Add new contributor ... and it gives me that message.

@Berkmann18
Copy link
Member

It seems like I get that error as well, I'm unable to look into it now but will do asap.

@Berkmann18
Copy link
Member

I've looked into it and can see why this happens but I'm unsure when that bug was introduced and I'm really busy at the moment so I can't seem to find what recent change caused this (especially since git blame points to fairly old contributions on the relevant LOCs).

Have you tried to reproduce this error with previous version?

@dexpota
Copy link
Contributor Author

dexpota commented Oct 12, 2019

The version 6.9.0 seems to work just fine.

@dexpota
Copy link
Contributor Author

dexpota commented Oct 16, 2019

I could look into this issue. This would be the first contribution for me on this project, do you think is it a good first-timer issue?

@Berkmann18
Copy link
Member

That would be amazing and welcome... And that goes in line with the other first-timer issues across AC repos.

So go ahead when you can 😀.

dexpota added a commit to dexpota/all-contributors-cli that referenced this issue Oct 17, 2019
@dexpota
Fix issue all-contributors#209
6cbec25
@dexpota dexpota mentioned this issue Oct 17, 2019
Merged
4 tasks
Berkmann18 pushed a commit that referenced this issue Oct 18, 2019
@dexpota @Berkmann18
fix: add contributions (#211)
97878f4 
* Fix issue #209

* Fix validation issue

* Add myself to contributors list
@yevhenorlov yevhenorlov mentioned this issue Oct 21, 2019
Merged
4 tasks
@Berkmann18
Copy link
Member

Just noticed this wasn't closed and yet fixed so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug status: available
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dexpota @Berkmann18