Skip to content

Commit

Permalink
fix: add contributions (#211)
Browse files Browse the repository at this point in the history
* Fix issue #209

* Fix validation issue

* Add myself to contributors list
  • Loading branch information
dexpota authored and Berkmann18 committed Oct 18, 2019
1 parent a91145f commit 97878f4
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 11 deletions.
10 changes: 10 additions & 0 deletions .all-contributorsrc
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,16 @@
"contributions": [
"code"
]
},
{
"login": "dexpota",
"name": "Fabrizio",
"avatar_url": "https://avatars1.githubusercontent.com/u/7031675?v=4",
"profile": "https://www.destro.me",
"contributions": [
"bug",
"code"
]
}
]
}
32 changes: 22 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
<!-- START doctoc generated TOC please keep comment here to allow auto update -->
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->

- [
all-contributors-cli
](#all-contributors-cli)
- [ all-contributors-cli ](#all-contributors-cli)
- [The problem](#the-problem)
- [This solution](#this-solution)
- [Using the all-contributors-cli](#using-the-all-contributors-cli)
- [Contributors](#contributors)
- [Contributors](#contributors-)
- [LICENSE](#license)

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

> [There is now a GitHub Bot](https://github.com/all-contributors/all-contributors-bot) for automating the maintenance of your contributors table ✨<br />Say goodbye to command line tool dependencies and hello to the [@all-contributors bot 🤖](https://github.com/all-contributors/all-contributors-bot)
> [There is now a GitHub Bot](https://github.com/all-contributors/all-contributors-bot)
> for automating the maintenance of your contributors table ✨<br />Say goodbye
> to command line tool dependencies and hello to the
> [@all-contributors bot 🤖](https://github.com/all-contributors/all-contributors-bot)
<h1 align="center">
all-contributors-cli
Expand Down Expand Up @@ -46,13 +47,14 @@
[![Code Coverage](https://img.shields.io/codecov/c/github/all-contributors/all-contributors-cli.svg)](https://codecov.io/github/all-contributors/all-contributors-cli)
[![Version](https://img.shields.io/npm/v/all-contributors-cli.svg)](https://www.npmjs.com/package/all-contributors-cli)
[![Downloads](https://img.shields.io/npm/dm/all-contributors-cli.svg)](http://www.npmtrends.com/all-contributors-cli)
[![All Contributors](https://img.shields.io/badge/all_contributors-34-orange.svg?style=flat-square)](#contributors-)
[![All Contributors](https://img.shields.io/badge/all_contributors-37-orange.svg?style=flat-square)](#contributors-)
[![Star on Github](https://img.shields.io/github/stars/all-contributors/all-contributors-cli.svg?style=social)](https://github.com/all-contributors/all-contributors-cli/stargazers)

## The problem

You want to implement the [All Contributors](https://github.com/all-contributors/all-contributors) spec, but don't
want to maintain the table by hand
You want to implement the
[All Contributors](https://github.com/all-contributors/all-contributors) spec,
but don't want to maintain the table by hand

## This solution

Expand All @@ -62,15 +64,19 @@ specification for your GitHub or GitLab repository.

## Using the all-contributors-cli

If you're looking to use the cli, head over to [the cli docs on allcontributors.org](https://allcontributors.org/docs/en/cli/overview). The all-contributors website contains all the information required to install, configure and use the all-contributors-cli.
If you're looking to use the cli, head over to
[the cli docs on allcontributors.org](https://allcontributors.org/docs/en/cli/overview).
The all-contributors website contains all the information required to install,
configure and use the all-contributors-cli.

## Contributors ✨

Thanks goes to these wonderful people
([emoji key](https://allcontributors.org/docs/en/emoji-key)):

<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
<!-- prettier-ignore -->
<!-- prettier-ignore-start -->
<!-- markdownlint-disable -->
<table>
<tr>
<td align="center"><a href="https://github.com/jfmengels"><img src="https://avatars.githubusercontent.com/u/3869412?v=3" width="100px;" alt="Jeroen Engels"/><br /><sub><b>Jeroen Engels</b></sub></a><br /><a href="https://github.com/all-contributors/all-contributors-cli/commits?author=jfmengels" title="Code">💻</a> <a href="https://github.com/all-contributors/all-contributors-cli/commits?author=jfmengels" title="Documentation">📖</a> <a href="https://github.com/all-contributors/all-contributors-cli/commits?author=jfmengels" title="Tests">⚠️</a></td>
Expand Down Expand Up @@ -120,8 +126,14 @@ Thanks goes to these wonderful people
<td align="center"><a href="https://github.com/simon300000"><img src="https://avatars1.githubusercontent.com/u/12656264?v=4" width="100px;" alt="simon3000"/><br /><sub><b>simon3000</b></sub></a><br /><a href="https://github.com/all-contributors/all-contributors-cli/commits?author=simon300000" title="Tests">⚠️</a></td>
<td align="center"><a href="https://sno2wman.dev/"><img src="https://avatars3.githubusercontent.com/u/15155608?v=4" width="100px;" alt="SnO₂WMaN"/><br /><sub><b>SnO₂WMaN</b></sub></a><br /><a href="https://github.com/all-contributors/all-contributors-cli/commits?author=SnO2WMaN" title="Code">💻</a></td>
</tr>
<tr>
<td align="center"><a href="https://www.destro.me"><img src="https://avatars1.githubusercontent.com/u/7031675?v=4" width="100px;" alt="Fabrizio"/><br /><sub><b>Fabrizio</b></sub></a><br /><a href="https://github.com/all-contributors/all-contributors-cli/issues?q=author%3Adexpota" title="Bug reports">🐛</a> <a href="https://github.com/all-contributors/all-contributors-cli/commits?author=dexpota" title="Code">💻</a></td>
</tr>
</table>

<!-- markdownlint-enable -->
<!-- prettier-ignore-end -->

<!-- ALL-CONTRIBUTORS-LIST:END -->

This project follows the
Expand Down
2 changes: 1 addition & 1 deletion src/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ function startGeneration(argv) {
}

function addContribution(argv) {
const username = String(argv._[1])
const username = argv._[1] === undefined ? undefined : String(argv._[1])
const contributions = argv._[2]
// Add or update contributor in the config file
return updateContributors(argv, username, contributions).then(data => {
Expand Down

0 comments on commit 97878f4

Please sign in to comment.