-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adapt to rst #301
feat: adapt to rst #301
Conversation
Adapt the indentation level of what's written to the initial indent of the opening tag. It should change nothing to markdown input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried pushing changes but it blocked me so I'll just write the changes as suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Maximilian Berkmann <maxieberkmann@gmail.com>
Co-authored-by: Maximilian Berkmann <maxieberkmann@gmail.com>
Co-authored-by: Maximilian Berkmann <maxieberkmann@gmail.com>
Co-authored-by: Maximilian Berkmann <maxieberkmann@gmail.com>
according to the image you send it seems that something is not running the way I would like, I'm trying to install the yarn project locally but I can't manage to make it work. I've cloned my brnach on my local computer and run : When I check |
Hmm, if you wanted to install the cli you should have done either:
or
Well, assuming you wanted to install it in a project and not as a dev/prod dependency. |
Sorry for the very late answer but i had no time to dedicate to this PR these past month. how can I test the cli in "dev" mode ? |
@12rambau That's fine, I was also very busy with other stuff. |
i ran Now if I want to use it (the local version from my computer) in a fake folder (to check waht happens) what should I do ?
And obviously the |
Have you tried running it from the root of the repo? |
I get the following error :
The use case is trivial, I've pulled the repository to my local computer, created a fake repository with nothing in it but a I'm sure it's 101 developing procedure. can you write down the steps to reproduce it from my end ? |
@12rambau I've fixed the checks. do you mind adding some tests? Thanks. |
first thank you very much for taking over the review of this PR ! |
@Berkmann18 I tested both .md and .rst are working |
@12rambau just install the latest version after we merged this one. can you verify if this one works well when you used it on your end? @Berkmann18 merging this one since this does not break the other tests. |
@all-contributors please add @12rambau for code |
I've put up a pull request to add @12rambau! 🎉 |
merging this one since this does not break the other tests.
🎉 This PR is included in version 6.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I still get the same errors as I was mentioning earlier in the thread, it may be related to my machine but I don't have the bandwidth to do a course on NPM packaging. I'll trust you on this one, as long as the table is indented relative to the code-block that's perfect. I'll wait until it's available via the bot to test it in my Python projects |
@12rambau you can try now |
Adapt the indentation level of what's written to the initial indent of the opening tag. It should change nothing to markdown input.
What:
The table and badge created by the CLI are raw HTML. They cannot be used in .rst fie because RST files are sensible to indentation. To be compatible the tool should get the indentation of the first tag and apply it to the rest of the content (as a global offset). #300
Why:
To make the tool compatible with .rst file => every doc created with Sphinx
How:
I'm getting the index of the last
\n
before the start Tag and I then replace every\n
of the newcontent with an appropriate number of extra spaces.Checklist:
Comments
I don't want/can add nodes dependencies to my project (that's why I was interested by the bot) so I can't test this functionality myself. I've authorized the edit by maintainer but let me know if I need to change things on my side.