[DC-3352] Fix bug EhrSubmissionDataCutoff.affected_tables is unset #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Uninitialized affected_tables causes reporter to fail with error getting sandbox table names [DC-3351]
mark-velez
force-pushed
the
mv/dc3352_affected_tables
branch
from
1dcbf59
to
f36632f
Compare
…f.get_affected_tables
mark-velez
force-pushed
the
mv/dc3352_affected_tables
branch
from
f36632f
to
15779a4
Compare
hiro-mishima
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
Thanks, @mark-velez! It looks good. I left another solution in the comment. Both ways exist in our code base, so this will be just a matter of preference. This PR is good to close.
Thanks 🎉
| tables.append(table) | ||
| return tables | ||
| sandbox_dataset_id=sandbox_dataset_id, | ||
| affected_tables=get_affected_tables()) |
There was a problem hiding this comment.
This works. We can also change this line to
affected_tables=[table for table in AOU_REQUIRED if table != 'person']
and remove get_affected_tables() altogether.
If we do that, patching for the test will be similar to this one: https://github.com/all-of-us/curation/blob/develop/tests/integration_tests/data_steward/cdr_cleaner/cleaning_rules/remove_records_with_wrong_date_test.py#L56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Uninitialized affected_tables causes reporter to fail with error getting sandbox table names DC-3351