Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nph (do not merge) #1865

Draft
wants to merge 16 commits into
base: develop
Choose a base branch
from
Draft

Nph (do not merge) #1865

wants to merge 16 commits into from

Commits on May 30, 2024

  1. Remove CT rules unrelated to NPH 

     * QRIDtoRID
 * TruncateEraTables
 * NullPersonBirthdate
 * TableSuppression
 * ControlledCopeSurveySuppression
 * DropOrphanedSurveyConductIds
 * DropOrphanedPIDS
 * GenerateWearStudyTable
 * DropViaSurveyConduct
 * RemoveExtraTables
 * CalculatePrimaryDeathRecord
 * CleanMappingExtTables
    @mark-velez @lledezma
    mark-velez authored and lledezma committed May 30, 2024
    Configuration menu
    Copy the full SHA
    fe957da View commit details
    Browse the repository at this point in the history

  2. Create datasets in location us-central1

    @mark-velez @lledezma
    mark-velez authored and lledezma committed May 30, 2024
    Configuration menu
    Copy the full SHA
    7f31ca5 View commit details
    Browse the repository at this point in the history

  3. Removed CT YearOfBirthRecordsSuppression because lack of person table… 

    … causes failure

see https://precisionmedicineinitiative.atlassian.net/browse/DL-176?focusedCommentId=194193
    @mark-velez @lledezma
    mark-velez authored and lledezma committed May 30, 2024
    Configuration menu
    Copy the full SHA
    f0b901a View commit details
    Browse the repository at this point in the history

  4. Limit affected tables for identifying_field_suppression to NPH tables

    @mark-velez @lledezma
    mark-velez authored and lledezma committed May 30, 2024
    Configuration menu
    Copy the full SHA
    95bcbdc View commit details
    Browse the repository at this point in the history

  5. Remove CT analytics csv data not applicable to NPH test data

    @mark-velez @lledezma
    mark-velez authored and lledezma committed May 30, 2024
    Configuration menu
    Copy the full SHA
    0a76d0e View commit details
    Browse the repository at this point in the history

  6. Add common.NPH_VOCABULARY_TABLES

    @mark-velez @lledezma
    mark-velez authored and lledezma committed May 30, 2024
    Configuration menu
    Copy the full SHA
    dd68c19 View commit details
    Browse the repository at this point in the history

  7. Remove bq tracing (breaks, not configured in warehouse project)

    @mark-velez @lledezma
    mark-velez authored and lledezma committed May 30, 2024
    Configuration menu
    Copy the full SHA
    42feb06 View commit details
    Browse the repository at this point in the history

  8. Restrict to NPH tables in build_and_copy_contents

    @mark-velez @lledezma
    mark-velez authored and lledezma committed May 30, 2024
    Configuration menu
    Copy the full SHA
    9f1dbf9 View commit details
    Browse the repository at this point in the history

  9. Select AOU-specific observation fields as NULL in build_and_copy_cont… 

    …ents
    @mark-velez @lledezma
    mark-velez authored and lledezma committed May 30, 2024
    Configuration menu
    Copy the full SHA
    498204a View commit details
    Browse the repository at this point in the history

  10. Update observation and measurement CDM schemas to include the NPH spe… 

    …cific field form_name
    @brendagutman @lledezma
    brendagutman authored and lledezma committed May 30, 2024
    Configuration menu
    Copy the full SHA
    26cade8 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Uncomment CTNPHObservationPrivacySuppression

    @mark-velez
    mark-velez committed May 31, 2024
    Configuration menu
    Copy the full SHA
    d3407ac View commit details
    Browse the repository at this point in the history

  2. Removing CTAdditionalPrivacyConceptSuppression and CTObservationPriva… 

    …cySuppression

CTAdditionalPrivacyConceptSuppression does not apply to observation table and are not relevant to NPH
CTObservationPrivacySuppression is based on non PPI/NPH concepts
    @mark-velez
    mark-velez committed May 31, 2024
    Configuration menu
    Copy the full SHA
    02cfdf4 View commit details
    Browse the repository at this point in the history

  3. Do not suppress NPH form_name field in string_fields_suppression

    @mark-velez
    mark-velez committed May 31, 2024
    Configuration menu
    Copy the full SHA
    40b3c56 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. NPH 2.0 generalization accommodation (#1867) 

    * NPH 2.0 generalization accomodation

* NPH remove the concept for suppression from the exception list
    @hiro-mishima
    hiro-mishima authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    1546019 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2024

  1. [DL-556] changes to run NPH on 1.0 

    * added two cleaning rules to NPH run list
* added NPH as a run list
* removed erroneous nulling of fields
    @lrwb-aou
    lrwb-aou committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    3ce0db3 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. [DL-556] 

    * fixing error that caused `geo_curr_hmcountry` to be null
* fixing comment to be accurate
    @lrwb-aou
    lrwb-aou committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    2438b6c View commit details
    Browse the repository at this point in the history