Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[risk=no] addressing sv vcf feedback 1 #1466

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[risk=no] addressing sv vcf feedback 1 #1466

merged 1 commit into from
Oct 10, 2024

Conversation

SrushtiGangireddy
Copy link
Collaborator

  1. “SV Variants” is redundant - “Structural Variants Variants”. Should just have “Structural Variants”
  2. Top of page says “SNV/Indel Variants” even when on SVs tab
  3. SVs tab should probably be next to variant search rather than after Participant demographics
  4. Need more example query types - region, gene
  5. Since we now have two variant types on that page, we need to change some titles also. In the screenshot - A and B should now be “Genomic Variants” and C should be “SNV/Indel Variants”
  6. Currently on test, B changes to Structural Variants when that tab is selected, but we can keep B as Genomic Variants at all times regardless of which tab is selected

@SrushtiGangireddy SrushtiGangireddy merged commit 6bd39cc into master Oct 10, 2024
5 checks passed
mhigbyflowers pushed a commit that referenced this pull request Oct 11, 2024
@SrushtiGangireddy @mhigbyflowers
addressing sv vcf feedback 1 (#1466)
220e1ef 
Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>
mhigbyflowers added a commit that referenced this pull request Oct 11, 2024
@mhigbyflowers @SrushtiGangireddy
[DB-1438][risk=no]State/territory heatmap prototype (#1467)
9d68d5e 
* init map us-all-territories

* [risk=no] SV VCF browser dev (#1446)

* wip

* wip

* trying to fix errors

* trying to fix errors

* trying to fix errors

* making size filter work

* making size filter work

---------

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* <meta name="title" (#1456)

* [risk=no] [DB-1145] Connect new CDR and VAT (#1457)

* connecting new cdr and vat

* new cdr

* new cdr

* change the latin american ancestry label to americas

* change the latin american ancestry label to americas

* test cdr release update

* DB-1437

---------

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* [risk=no] [DB-1442] Add new genomic FAQ in SNV/Indel variants section (#1459)

* Add new genomic FAQ in SNV/Indel variants section

* Add new genomic FAQ in SNV/Indel variants section

---------

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* [risk=no] [DB-1440] Adding EHR concept's location count data (#1460)

* Wip

* Wip

* Wip

* Wip

* Wip

* Wip

* Wip

* Wip

* adding ehr location count data

* adding ehr location count data

---------

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* [risk=no] [DB-1440] Part 2 of this ticket generating location data for surveys, genomics  (#1461)

* survey queries for location data

* survey queries for location data

* survey queries for location data

* survey queries for location data

* survey queries for location data

---------

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* [risk=no] [PD-14784] Genetic Variant Search Changes and DOS application hang up fix (#1462)

* survey queries for location data

* survey queries for location data

* survey queries for location data

* survey queries for location data

* survey queries for location data

* trying to fix DOS breakage on <

---------

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* reverting cdr update and pushing to test (#1463)

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* wip

* adding map to ehr wip

* wip;

* rm log

* adding heatmap env vars

* remove map route

* gating the heatmap via env

* heatmap w/ data

* fixing route error (#1465)

* [risk=no] upgrading wildcards in privileges (#1464)

* upgrading wildcards in privileges

* upgrading wildcards in privileges

---------

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* addressing sv vcf feedback 1 (#1466)

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* rm comment

---------

Co-authored-by: Srushti Gangireddy <srushti.gangireddy@gmail.com>
Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>
SrushtiGangireddy added a commit that referenced this pull request Oct 11, 2024
@mhigbyflowers @SrushtiGangireddy
[DB-1438][risk=no]State/territory heatmap prototype (#1467)
973e8fb 
* init map us-all-territories

* [risk=no] SV VCF browser dev (#1446)

* wip

* wip

* trying to fix errors

* trying to fix errors

* trying to fix errors

* making size filter work

* making size filter work

---------

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* <meta name="title" (#1456)

* [risk=no] [DB-1145] Connect new CDR and VAT (#1457)

* connecting new cdr and vat

* new cdr

* new cdr

* change the latin american ancestry label to americas

* change the latin american ancestry label to americas

* test cdr release update

* DB-1437

---------

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* [risk=no] [DB-1442] Add new genomic FAQ in SNV/Indel variants section (#1459)

* Add new genomic FAQ in SNV/Indel variants section

* Add new genomic FAQ in SNV/Indel variants section

---------

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* [risk=no] [DB-1440] Adding EHR concept's location count data (#1460)

* Wip

* Wip

* Wip

* Wip

* Wip

* Wip

* Wip

* Wip

* adding ehr location count data

* adding ehr location count data

---------

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* [risk=no] [DB-1440] Part 2 of this ticket generating location data for surveys, genomics  (#1461)

* survey queries for location data

* survey queries for location data

* survey queries for location data

* survey queries for location data

* survey queries for location data

---------

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* [risk=no] [PD-14784] Genetic Variant Search Changes and DOS application hang up fix (#1462)

* survey queries for location data

* survey queries for location data

* survey queries for location data

* survey queries for location data

* survey queries for location data

* trying to fix DOS breakage on <

---------

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* reverting cdr update and pushing to test (#1463)

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* wip

* adding map to ehr wip

* wip;

* rm log

* adding heatmap env vars

* remove map route

* gating the heatmap via env

* heatmap w/ data

* fixing route error (#1465)

* [risk=no] upgrading wildcards in privileges (#1464)

* upgrading wildcards in privileges

* upgrading wildcards in privileges

---------

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* addressing sv vcf feedback 1 (#1466)

Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>

* rm comment

---------

Co-authored-by: Srushti Gangireddy <srushti.gangireddy@gmail.com>
Co-authored-by: Srushti Gangireddy <shrushigangireddy@NLDMIMX3N6D59RJ.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhigbyflowers mhigbyflowers mhigbyflowers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SrushtiGangireddy @mhigbyflowers