Skip to content

Commit

Permalink
ClientAwaitedAction now uses a channel to notify drops happened (Trac…
Browse files Browse the repository at this point in the history
…eMachina#1130)

Instead of using Weak references and custom spawns, we now use
a channel to notify receivers that cleanups are needed.
  • Loading branch information
allada authored Jul 10, 2024
1 parent 52beaf9 commit 5e98ec9
Show file tree
Hide file tree
Showing 3 changed files with 139 additions and 148 deletions.
1 change: 0 additions & 1 deletion nativelink-scheduler/src/cache_lookup_scheduler.rs
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ impl ActionScheduler for CacheLookupScheduler {
.await;
match maybe_action_result {
Ok(action_result) => {
println!("{action_result:?}");
let maybe_pending_txs = {
let mut inflight_cache_checks = inflight_cache_checks.lock();
// We are ready to resolve the in-flight actions. We remove the
Expand Down
2 changes: 1 addition & 1 deletion nativelink-scheduler/src/scheduler_state/awaited_action.rs
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ pub struct AwaitedAction {
action_info: Arc<ActionInfo>,

// The unique identifier of the operation.
// TODO(operation_id should be stored here).
// TODO!(operation_id should be stored here).
// operation_id: OperationId,
/// The data that is used to sort the action in the queue.
/// The first item in the tuple is the current priority,
Expand Down
Loading

0 comments on commit 5e98ec9

Please sign in to comment.