DS-10606 extent api requests to allow for basic auth #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoughtelin
approved these changes
Jan 16, 2024
| return $this->hasBasicAuth; | ||
| } | ||
|
|
||
| public function setHasBasicAuth($hasBasicAuth) |
There was a problem hiding this comment.
Maybe throw some :void return types on these setters, assuming this won't be digested by any service lower than PHP 7.1
nicholasmejia
approved these changes
Jan 16, 2024
|
Re thinking how we want to auth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
extend api requests to allow for basic auth
Jira Issue Link
https://alldigitalrewards.atlassian.net/browse/DS-10606
Has the README / documentation been extended if necessary?
No
Does this update require changes to public API documentation?
No
Tests
Are there created tests which fail without the change (if possible)?
No
Have the changes been verified to comply with the security policy requirements?
Yes