Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot dependencies checker ignores gradle Project and ProjectDependencyConstraint #831

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Snapshot dependencies checker ignores gradle Project and ProjectDependencyConstraint #831

merged 1 commit into from
Oct 4, 2024
+46 −17

Conversation

bgalek
Copy link
Member

@bgalek bgalek commented Oct 4, 2024

No description provided.

@bgalek bgalek force-pushed the SnapshotDependenciesChecker_includes_gradle_projects branch from 58fb93f to bf6e8d3 Compare October 4, 2024 10:06
@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.74%. Comparing base (a158fe6) to head (fe48fe0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...on/release/domain/SnapshotDependenciesChecker.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #831      +/-   ##
============================================
+ Coverage     63.66%   63.74%   +0.07%     
  Complexity      442      442              
============================================
  Files            82       82              
  Lines          1635     1633       -2     
  Branches        161      161              
============================================
  Hits           1041     1041              
+ Misses          525      523       -2     
  Partials         69       69

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgalek bgalek force-pushed the SnapshotDependenciesChecker_includes_gradle_projects branch 3 times, most recently from e4dab4a to a701223 Compare October 4, 2024 11:04
@bgalek
graadle module dependnecies that have the same version as root projec…
fe48fe0 
…t should not be detected as snapshots | fixes #827
@bgalek bgalek force-pushed the SnapshotDependenciesChecker_includes_gradle_projects branch from a701223 to fe48fe0 Compare October 4, 2024 14:50
@bgalek bgalek changed the title Snapshot dependencies checker includes gradle projects Snapshot dependencies checker ignores gradle projects Oct 4, 2024
@bgalek bgalek changed the title Snapshot dependencies checker ignores gradle projects Snapshot dependencies checker ignores gradle Project and ProjectDependencyConstraint Oct 4, 2024
@bgalek bgalek merged commit 394045f into main Oct 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bgalek