Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inner wrapping of heading content #7

Merged
merged 1 commit into from
Nov 25, 2018

Conversation

allejo
Copy link
Owner

@allejo allejo commented Nov 21, 2018

Added 'bodyPrefix' and 'bodySuffix' options to the snippet allowing for users to wrap the inner contents of a heading.

Fixes #5

Does this solve your problem, @MartijnCuppens @XhmikosR?

- Added 'bodyPrefix' and 'bodySuffix' options to the snippet allowing
  for users to wrap the inner contents of a heading
- Refactor how headings are modified to be easier to understand for
  future changes
@XhmikosR
Copy link

Hey, @allejo. Thanks for this!

Unfortunately we had to revert the switch to jekyll-anchor-headings because our docs have many cases we needed to exclude it and it's messy.

So, it's your call if you want this merged or not.

Thanks for the quick implementation :)

@allejo
Copy link
Owner Author

allejo commented Nov 25, 2018

Ah, well that's a shame but understandable, Bootstrap's docs does mix a lot of content with examples.

Well I'll merge this in, maybe someone will have a use for it 🤷‍♂️

@allejo allejo merged commit 41bf3de into master Nov 25, 2018
@allejo allejo deleted the feature/heading-wrappers branch November 25, 2018 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap heading content support?
2 participants