Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reorg renderlib #110

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Feature/reorg renderlib #110

merged 2 commits into from
Jun 16, 2023

Conversation

toloudis
Copy link
Contributor

@toloudis toloudis commented Jun 6, 2023

This code change should have no effect on any functionality at all and is just moving some files.

Move io-related files into an io/ subdirectory.
Move OpenGL graphics related files into a graphics/ subdirectory.
This allows a bit of logical organization to help pave the way for future changes that may be graphics-only (or data-loading only).
It also encapsulates some dependencies that are only relevant for io : tensorstore and libCZI.

For some reason, git recognized that some files were moved and others seem to show full diffs even though they are unchanged and only moved.

kmitcham
kmitcham previously approved these changes Jun 8, 2023
Copy link

@kmitcham kmitcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"I owe, I owe, its off to work I go..."

Base automatically changed from fix/scroll-focus-controls to main June 16, 2023 00:26
@toloudis toloudis dismissed kmitcham’s stale review June 16, 2023 00:26

The base branch was changed.

@toloudis toloudis merged commit a4befd9 into main Jun 16, 2023
@toloudis toloudis deleted the feature/reorg-renderlib branch June 16, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants