add option to keep current agave settings when loading #160
Conversation
toloudis
requested review from
meganrm,
blairlyons,
interim17,
ShrimpCryptid,
frasercl and
ascibisz
and removed request for
a team
| m_appScene.initSceneFromImg(image); | ||
| m_glView->initCameraFromImage(&m_appScene); | ||
| m_appScene.initBoundsFromImg(image); | ||
| if (!keepCurrentUISettings || !wasVolumeLoaded) { |
There was a problem hiding this comment.
this is where we use the checkbox value to either reset settings or not
| layout->addRow("Keep current AGAVE settings", m_keepSettingsCheckbox); | ||
| layout->addItem(new QSpacerItem(0, spacing, QSizePolicy::Expanding, QSizePolicy::Expanding)); |
There was a problem hiding this comment.
Nit: AGAVE settings to me suggests the configuration/settings for the entire AGAVE application (almost like user preferences), rather than just the current viewer settings. Would "viewer settings" or "volume settings" be more clear?
|
It seems like any changes to the ROI on the LoadDialog are overridden when keeping the existing settings. Is this intended behavior? UI has an existing ROI, and the LoadDialog has a different ROI set: Once the image is loaded, it keeps the old ROI range, ignoring what was set in LoadDialog: |
I think this is actually the correct/intended behavior. The ROI in the loading dialog is letting you select a subset of what's in the original file to load. Once that is loaded, that volume becomes the ENTIRE volume that the app knows about. So if your loading ROI starts at x0, y0, z0 and spans a size of dx, dy, dz, then the LOADED volume (and the ROI you see in the appearance panel ROI section) will start at 0,0,0 and be of size dx,dy,dz. The saved settings of ROI in the Appearance panel preserve the relative ROI selection relative to the volume that was loaded. |
If loading a new volume, offer a LoadDialog checkbox to keep or discard current volume appearance settings. Default is to keep settings. This is to make it efficient when loading consecutive images of same channels and approximate intensity ranges. Unchecking the box will present the previous behavior, where every setting goes back to a default.
Example: load a 9-channel variance dataset volume, enable a set of channels. Customize channel colors. Adjust thresholding. Then load another 9-channel variance dataset volume. Same channels should be enabled, with same colors etc.