Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ant Design v5 #165

Closed
53 tasks done
ShrimpCryptid opened this issue May 29, 2024 · 0 comments · Fixed by #166
Closed
53 tasks done

Upgrade to Ant Design v5 #165

ShrimpCryptid opened this issue May 29, 2024 · 0 comments · Fixed by #166
Assignees
Labels
enhancement New feature or request

Comments

@ShrimpCryptid
Copy link
Contributor

ShrimpCryptid commented May 29, 2024

Use Case

Making this to track progress on Cell Feature Explorer!

  • Fix font usage
  • Cookie banner
    • Fix font in cookie banner
  • Landing page
    • Fix card radii
    • Fix title colors
    • Fix background color
    • Fix bad colon position on dataset descriptors
    • Font size for text
    • Link color
  • Change theme color
  • Change button radius
  • Remove button shadow
  • Header
    • Fix alignment
    • Fix background color
  • Loader
    • Fix spinner + text colors
  • Viewer
    • Small screen warning bg color
    • Small screen warning checkbox color
    • Fix gallery tab being on left instead of right
    • Fix missing label on gallery tab
    • Menu tabs cannot be clicked directly
    • Fix spacing on tabs
    • Fix color on selected tabs
    • Fix theme color used on checkboxes
    • Fix colors on "Viewing cell" text
    • Fix strange whitespace at the bottom of the page
    • Fix broken dropdowns due to API change
    • Make link text (axis glossary) a lighter color
    • Fix tooltip not moving with mouse
    • Remove border on tooltip
    • Dropdowns on plot are layered over gallery
    • Plot extends into gallery area
    • Download dropdowns extend past screen edges Existing bug
    • Plot/3D Viewer tabs are too tall
    • Allow dropdowns to auto-size
    • Cell title on 3d viewer goes off of the edge
    • Carets on dropdowns are the wrong color
    • Gap at bottom of plot view
    • Increase font size of icons
  • Gallery
    • Fix bad album text color
    • Fix close button
    • Fix album text not being aligned on top of selections
    • Fix alert background color on deletion
    • Add transparency effect back to Gallery background
    • Fix searchbar extending into scroll area
    • Fix bad card button layout on selections
    • Fix bad sizing on gallery overlay
    • Fix bad layout on gallery overlay
    • Pad gallery buttons
@ShrimpCryptid ShrimpCryptid added the enhancement New feature or request label May 29, 2024
@ShrimpCryptid ShrimpCryptid self-assigned this May 29, 2024
@ShrimpCryptid ShrimpCryptid linked a pull request May 30, 2024 that will close this issue
3 tasks
@ShrimpCryptid ShrimpCryptid removed a link to a pull request May 30, 2024
3 tasks
@ShrimpCryptid ShrimpCryptid linked a pull request Jun 13, 2024 that will close this issue
ShrimpCryptid added a commit that referenced this issue Jun 18, 2024
- Removes old Less styling rules and replaces it with Ant's new `ConfigProvider` model.
- Fixed an existing bug where, on narrow screens, parts of the Gallery could not be interacted with.
- Fixed an existing bug where a gap would appear next to the main plot view.
- Fixes a list of roughly 50 UI-related issues, as noted in #165.

Full changes:
* fix: Changed props for ImageViewerApp to match new w3cv API

* refactor: Upgrade web-3d-viewer to 2.9.0

* fix: Fix styling on channel settings tab due to ant version or font

* fix:  Fixed missing ant drawer

* fix: Icons in toolbar were off-center

* fix: Missing type declaration in tests

* test: Update CI action to node v20

* test: Import type declarations

* test: Use original type declaration import, change CI action ordering

* fix: Fixed build issues caused by local w3cv project instance being included in package-lock.json

* refactor: Upgrade to Ant ^5.16.2, fix compile issues

* fix: Removed unsupported babel plugin

* fix: Text colors, title colors, header font weight

* fix: Page background color, link color

* fix: Header alignment

* fix: Button colors and shadows, landing page text size

* fix: Title color, paragraph padding, table margins

* fix: Bad colon alignment on dataset descriptions

* fix: Layout issues on viewer page

* fix: Loading spinner color

* fix: Header colors, alignment

* feat: Increased tab icon sizes, alignment fixes

* refactor: Make palette colors a constant

* fix: Fixed overlap of viewer title and menu tab buttons

* fix: Header menu tab styling

* fix: Incorrect font in cookie banner

* fix: Sider background colors

* fix: Card action formatting

* fix: Gallery background width, transparency

* fix: Button and icon styling on gallery sidebar

* fix: Action list on button icons

* fix: Menu header being the incorrect height

* fix: Album list hover and selection colors

* fix: Removed extra margin at bottom of page caused by gallery sider

* fix: Unclickable gallery close button, searchbar overlapping scrollbar

* fix: Removed deprecated properties on menus, modals, and dropdowns

* fix: Checkbox colors

* fix: Fixed 3d viewer and plot extending into gallery sider

* fix: Close button on selected set

* fix: Album text alignment

* fix: Popconfirm background color, removed button shadows

* fix: Axis dropdown not changing on selection, showing keys instead of names on dropdown

* feat: Adjusted selected set delete button style

* fix: Style matching on thumbnail popover

* fix: Popover now follows mouse

* refactor: Deleted unused style CSS

* feat: Adjusted margin on gallery buttons

* fix: Gallery card button spacing, fixed download dropdown

* fix: Dropdowns extending up into header and being unclickable

* fix: Temporarily fixed dropdowns by overriding width

* fix: Linting

* refactor: Restored .gitkeep

* refactor: Import sorting, renamed variables

* refactor: Palette now has base colors to prevent reused strings

* refactor: Code cleanup, increased tab icon size

* fix: Alignment of 3d viewer text, increased plot height

* fix: Dropdown arrow color, dropdown width

* fix: Alignment on gallery header

* refactor: Removed style overrides for CellViewer

* refactor: Removed unused less dependencies

* refactor: Removed additional unused dependencies

* refactor: Sorted imports, moved CSS

* refactor: Moved imports, prevented theme re-calculation

* refactor: Use single JSX tag instead of opening + closing tags

Co-authored-by: Cameron Fraser <53030214+frasercl@users.noreply.github.com>

* refactor: More import sorting, removed unused CSS

* fix: Disabled button styling in Gallery view

* fix: Linting

---------

Co-authored-by: Cameron Fraser <53030214+frasercl@users.noreply.github.com>
ShrimpCryptid added a commit that referenced this issue Sep 24, 2024
- Removes old Less styling rules and replaces it with Ant's new `ConfigProvider` model.
- Fixed an existing bug where, on narrow screens, parts of the Gallery could not be interacted with.
- Fixed an existing bug where a gap would appear next to the main plot view.
- Fixes a list of roughly 50 UI-related issues, as noted in #165.

Full changes:
* fix: Changed props for ImageViewerApp to match new w3cv API

* refactor: Upgrade web-3d-viewer to 2.9.0

* fix: Fix styling on channel settings tab due to ant version or font

* fix:  Fixed missing ant drawer

* fix: Icons in toolbar were off-center

* fix: Missing type declaration in tests

* test: Update CI action to node v20

* test: Import type declarations

* test: Use original type declaration import, change CI action ordering

* fix: Fixed build issues caused by local w3cv project instance being included in package-lock.json

* refactor: Upgrade to Ant ^5.16.2, fix compile issues

* fix: Removed unsupported babel plugin

* fix: Text colors, title colors, header font weight

* fix: Page background color, link color

* fix: Header alignment

* fix: Button colors and shadows, landing page text size

* fix: Title color, paragraph padding, table margins

* fix: Bad colon alignment on dataset descriptions

* fix: Layout issues on viewer page

* fix: Loading spinner color

* fix: Header colors, alignment

* feat: Increased tab icon sizes, alignment fixes

* refactor: Make palette colors a constant

* fix: Fixed overlap of viewer title and menu tab buttons

* fix: Header menu tab styling

* fix: Incorrect font in cookie banner

* fix: Sider background colors

* fix: Card action formatting

* fix: Gallery background width, transparency

* fix: Button and icon styling on gallery sidebar

* fix: Action list on button icons

* fix: Menu header being the incorrect height

* fix: Album list hover and selection colors

* fix: Removed extra margin at bottom of page caused by gallery sider

* fix: Unclickable gallery close button, searchbar overlapping scrollbar

* fix: Removed deprecated properties on menus, modals, and dropdowns

* fix: Checkbox colors

* fix: Fixed 3d viewer and plot extending into gallery sider

* fix: Close button on selected set

* fix: Album text alignment

* fix: Popconfirm background color, removed button shadows

* fix: Axis dropdown not changing on selection, showing keys instead of names on dropdown

* feat: Adjusted selected set delete button style

* fix: Style matching on thumbnail popover

* fix: Popover now follows mouse

* refactor: Deleted unused style CSS

* feat: Adjusted margin on gallery buttons

* fix: Gallery card button spacing, fixed download dropdown

* fix: Dropdowns extending up into header and being unclickable

* fix: Temporarily fixed dropdowns by overriding width

* fix: Linting

* refactor: Restored .gitkeep

* refactor: Import sorting, renamed variables

* refactor: Palette now has base colors to prevent reused strings

* refactor: Code cleanup, increased tab icon size

* fix: Alignment of 3d viewer text, increased plot height

* fix: Dropdown arrow color, dropdown width

* fix: Alignment on gallery header

* refactor: Removed style overrides for CellViewer

* refactor: Removed unused less dependencies

* refactor: Removed additional unused dependencies

* refactor: Sorted imports, moved CSS

* refactor: Moved imports, prevented theme re-calculation

* refactor: Use single JSX tag instead of opening + closing tags

Co-authored-by: Cameron Fraser <53030214+frasercl@users.noreply.github.com>

* refactor: More import sorting, removed unused CSS

* fix: Disabled button styling in Gallery view

* fix: Linting

---------

Co-authored-by: Cameron Fraser <53030214+frasercl@users.noreply.github.com>

refactor: Upgrade web-3d-viewer to 2.9.0

fix: Fix styling on channel settings tab due to ant version or font

fix: Icons in toolbar were off-center

fix: Missing type declaration in tests

test: Update CI action to node v20

test: Import type declarations

test: Use original type declaration import, change CI action ordering

fix: Fixed build issues caused by local w3cv project instance being included in package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant