fix thumbnail indexing #103

toloudis · 2022-05-30T00:36:38Z

Problem

From Graham:

Mac Monterey 12.4 running latest Chrome. 
Opened cfe and selected main variance dataset.  
Delesected all and then tried to load only Endoplasmic reticulum.  
No thumnails show up and clicking any dots won't load anything into the gallery.
Same issue for Mitochondria... probably all of them
Thumbs etc only available when ShowAll

Solution

Thumbnail in plot was using wrong index.

Type of change

Bug fix (non-breaking change which fixes an issue)

meganrm · 2022-05-31T16:59:54Z

src/containers/MainPlotContainer/selectors.ts

-                index,
-                thumbnailPath: thumbnailPaths[index],
+                index: cellIndex,
+                thumbnailPath: thumbnailPaths[i],


that's a lot of indices

fix thumbnail indexing

c6bc0b2

toloudis requested review from meganrm and schoinh as code owners May 30, 2022 00:36

meganrm approved these changes May 31, 2022

View reviewed changes

meganrm reviewed May 31, 2022

View reviewed changes

toloudis merged commit defebcb into main Jun 7, 2022

toloudis deleted the fix/broken-thumbnails-selected branch June 7, 2022 23:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix thumbnail indexing #103

fix thumbnail indexing #103

toloudis commented May 30, 2022 •

edited

Loading

meganrm May 31, 2022

fix thumbnail indexing #103

fix thumbnail indexing #103

Conversation

toloudis commented May 30, 2022 • edited Loading

Problem

Solution

Type of change

meganrm May 31, 2022

Choose a reason for hiding this comment

toloudis commented May 30, 2022 •

edited

Loading