Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Bump dependencies #212

Merged
merged 5 commits into from
Nov 11, 2024
Merged

refactor: Bump dependencies #212

merged 5 commits into from
Nov 11, 2024

Conversation

ShrimpCryptid
Copy link
Contributor

@ShrimpCryptid ShrimpCryptid commented Oct 25, 2024

Problem

Closes #162, upgrade 3d viewer.

Upgrades w3cv dependency and also bumps packages to resolve vulnerabilities. Note that we are still using an older version of firebase, as the API has changed significantly between the current version (7.x.x) and the newer versions (11.x.x).

Estimated review size: tiny, <5 minutes

Solution

  • Ran npm audit fix --force
  • Upgrade web-3d-viewer to v2.10.2.
  • Changed mocha.opts to .mocharc for compatibility.

Video Demo (🔊):

2024-11-05.10-48-42.mp4

@ShrimpCryptid ShrimpCryptid self-assigned this Oct 25, 2024
@ShrimpCryptid
Copy link
Contributor Author

Waiting on allen-cell-animated/website-3d-cell-viewer#333 to merge to fix a bug in reset behaviors

@ShrimpCryptid ShrimpCryptid marked this pull request as ready for review November 5, 2024 18:58
@ShrimpCryptid ShrimpCryptid requested a review from a team as a code owner November 5, 2024 18:58
@ShrimpCryptid ShrimpCryptid requested review from toloudis and interim17 and removed request for a team November 5, 2024 18:59
Copy link
Contributor

@toloudis toloudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShrimpCryptid ShrimpCryptid merged commit ee03ed2 into main Nov 11, 2024
1 check passed
@ShrimpCryptid ShrimpCryptid deleted the refactor/bump-dependencies branch November 11, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maintenance: upgrade 3d viewer
3 participants