Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sort megacards from newest to oldest #90

Merged
merged 4 commits into from
Feb 14, 2022
Merged

Conversation

schoinh
Copy link
Contributor

@schoinh schoinh commented Feb 11, 2022

Problem

Resolves: Sort megacards from newest to oldest

Solution

@meganrm has added a dateCreated timestamp for each megaset in the test database, so the megasets are now sorted from newest to oldest before being rendered as megacards. (The plan is to modify the Firebase scripts soon so that the timestamps are added automatically for newly uploaded datasets)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires updated or new tests

Change summary:

  • Wrote new sorting function and test
  • Removed old sorting function and tests

Steps to Verify:

  1. Pull this branch and npm run start:test-db
  2. Verify that the datasets are in the order we want, as shown in the screenshot below

Screenshots (optional):

image

Thanks for contributing!

@schoinh schoinh merged commit ecc16d1 into main Feb 14, 2022
@schoinh schoinh deleted the feature/megaset-sorting branch February 14, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants