Mark Format serialization failures as step failure (#421)

allenai · Sep 26, 2022 · 747469f · 747469f
1 parent b1d6431
commit 747469f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - Long log lines will be soft-wrapped to ensure that links are clickable.
+- Fixed a bug where some workspaces could be left in a bad state if a step's `Format` failed to serialize the step's result in `Workspace.step_finished()`.
 
 ## [v0.14.0](https://github.com/allenai/tango/releases/tag/v0.14.0) - 2022-09-20
 

diff --git a/tango/step.py b/tango/step.py
@@ -420,12 +420,12 @@ def _run_with_work_dir(self, workspace: "Workspace", needed_by: Optional["Step"]
 
             try:
                 result = self.run(**kwargs)
+                result = workspace.step_finished(self, result)
             except BaseException as e:
                 self.log_failure(e)
                 workspace.step_failed(self, e)
                 raise
 
-            result = workspace.step_finished(self, result)
             self.log_finished()
             return result
         finally: