-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Support for Self-Hosted Gitlab. #115
base: main
Are you sure you want to change the base?
Conversation
…uch function will generate an appropriate gitlab client based on the configurations provided by the user.
@dimabru Hey! Hope you're doing great! I started to implement the feature and I'm taking the path you mentioned (adding a key to the I know you might be busy, so feel free to answer when you have some free time c: |
Hey @jmj0502, What I suggest to do here is this: Line 11 in 7e9c8cd
I suggest gitlabClientUrl
Once you're done with that, users should be able to run Then, you will need to add a custom url to the gitlabClient.go file - I'm not sure how, need to check their documentation. Please let me know if there's anything else I can help with, and thanks a lot for the contribution! |
…ests require a custom gitlabURL.
@dimabru Hey! Thanks for the guidance. I think I'm done! We just need to test using a real custom gitlab URL (I don't have any), based on the dummy test I performed, I would say the feature is almost done. |
@jmj0502 ok great! Make sure to change the pr title to match commit convention |
@dimabru Donee! The title and the description were updated, in order to meet the provided commit convention. |
hey @jmj0502, Sorry for the inconvenience and once again, thanks for contributing :) |
@dimabru Hey! Hope you're doing great! No worries! I'll be ready in case any change is needed 👍 |
I'l test it tomorrow! |
Here's what I did:
When I run So I guess the new implementation does work. However there are some other features that need to be implemented in order for it to be useful. Also archived repositories are also fetched which is unexpected for me. |
@rndmh3ro Hey! Hope you're doing well! Sorry for the late reply (I've been busy at work) and thanks for this huge help. Cool! The bugs are probably related with missing configurations at the gitlab client level, I'll work on the improvements and let you know when I'm done so you can test again. |
Solves #78
clients/gitlabClient.go
; thegenerateGitlabClient
function will generate a common client or client with a custom URL extracted from the configurations provided by the user.gitlabClientURL
config key was added to list ofConfigAvailableKeys
on the filecmd/config/main.go
file.