Change the index setting so it can handle site in a directory #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, and thanks for the PR! Before I merge I'm going to add unit tests and I'm going to tweak this solution to ensure that the index name is only alphanumeric characters, dashes, and underscores. |
Closed
|
Cool. If you want a hand with this, I can take a crack at it. |
|
FWIW I'm using this patch on sites we have in |
|
Should maybe look at this and expand what characters are not allowed. There are a number of other characters in ES that are reserved for special operations on indices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
localhost/wordpress as the index name confuses elasticsearch. I've replaced the slashes with underscores.