-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suggestion for additional parameter-tweaking-support #241
Comments
This can possibly solve your problem... making them higher will produce
thicker lines. But this can also cause another problem: thin lines will not
be detected!
Will keep this open so I can put this on a parameter in the future.
Em seg., 30 de nov. de 2020 às 12:33, musikdusche <notifications@github.com>
escreveu:
… Dear OpenNoteScanner-Team,
I'm starting to use the program and it's conveniently simple and fine so
far. Thank you very much for this piece of software!
But I'm having trouble getting good results, if the scanned document
contains thick lines (for example a text on an A4-page with a felt-tip-pen
or flipchart-marker). In this case you get an "edge-detection"-like effect.
I had a look into your source code and you are using the following
function-call (two times in ImageProcessor.java):
Imgproc.adaptiveThreshold(mask,mask,255,Imgproc.ADAPTIVE_THRESH_MEAN_C,Imgproc.THRESH_BINARY_INV,15,15);
The last two values 15 and 15 are hardcoded into your source. If I am
understanding the OpenCV-adaptiveThreshold parameters right, tweaking these
two numbers should solve my problem. Would it be possible to make these two
numbers configurable in the app-settings dialog? (I am not an app-dev
myself so I have no idea if implementing this is a lot of work and thus too
much to ask.)
Thank you very much for your work!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#241>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOKDUHAZKLMXP5UKJ737YDSSO3LJANCNFSM4UHXJB2Q>
.
|
I am pretty sure this isn't true. From the OpenCV-docs concerning the two "15"-parameters in your code:
So, with blockSize you set certain neighbourhood-size. If that size is very big, you only get problems, if the backround-value changes are too big inside this neighbourhood - which won't be the case if you only take a neighbourhood 15 pixels wide on a 16Megapixel-smartphone photo. What could happen is this:
Thank you for your patience and attention. Greetings from Düsseldorf, Germany. |
Dear OpenNoteScanner-Team,
I'm starting to use the program and it's conveniently simple and fine so far. Thank you very much for this piece of software!
But I'm having trouble getting good results, if the scanned document contains thick lines (for example a text on an A4-page with a felt-tip-pen or flipchart-marker). In this case you get an "edge-detection"-like effect.
I had a look into your source code and you are using the following function-call (two times in ImageProcessor.java):
Imgproc.adaptiveThreshold(mask,mask,255,Imgproc.ADAPTIVE_THRESH_MEAN_C,Imgproc.THRESH_BINARY_INV,15,15);
The last two values 15 and 15 are hardcoded into your source. If I am understanding the OpenCV-adaptiveThreshold parameters right, tweaking these two numbers should solve my problem. Would it be possible to make these two numbers configurable in the app-settings dialog? (I am not an app-dev myself so I have no idea if implementing this is a lot of work and thus too much to ask.)
Thank you very much for your work!
The text was updated successfully, but these errors were encountered: