Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persian Translation #194

Merged
merged 4 commits into from
Jun 23, 2020
Merged

Persian Translation #194

merged 4 commits into from
Jun 23, 2020

Conversation

ahangarha
Copy link
Contributor

@ahangarha ahangarha commented Jun 9, 2020

Description

Persian translation done

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

I have not tested as I don't have androin dev env at the moment. But logically it should work.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Since I havent made any modification in code, some of the above items are not relevant to this PR

@allgood
Copy link
Owner

allgood commented Jun 18, 2020

Hi @ahangarha

Noted you created more files than needed. Can you please resubmit only with strings.xml file and a translated version of about.md file?

Note that to translate about.md you need to create about-fa.md and change the value of about_filename on strings.xml to reference it. You can look at commit 3931965 for an example on how to do it.

@ahangarha
Copy link
Contributor Author

Thank you for correction. Please check if everything is fine now.

@allgood
Copy link
Owner

allgood commented Jun 20, 2020

Hi @ahangarha , only one little thing missing.

On line 16 of strings.xml you must refer to your translated about file, like this:

<string name="about_filename">about-fa.md</string>

@allgood allgood closed this Jun 20, 2020
@allgood allgood reopened this Jun 20, 2020
@ahangarha
Copy link
Contributor Author

Sorry for my problematic work. I hope it be over now :)

@allgood allgood merged commit 41482a1 into allgood:master Jun 23, 2020
@allgood
Copy link
Owner

allgood commented Jun 23, 2020

thank you @ahangarha

in no way it is a problematic work! it is awesome! Sorry to ask you for this minor changes, I asked because this way all the integration lists as yours!

Please subscribe to issue #35 , I will inform there always when there is new strings to be translated.

Best regards, and thank you again.
Claudemir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants