Fix standalone SourceHook compilation #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychonic
force-pushed
the
psy/ci-fixes
branch
2 times, most recently
from
497c251
to
148ecd3
Compare
psychonic
force-pushed
the
psy/ci-fixes
branch
2 times, most recently
from
23ee687
to
76077dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This slipped by since we didn't have CI running for PRs to any branch except for master. SourceHook was dependent on the
mm_LogMessagefunction which only exists when SourceHook is embedded in MM:S.While that's the primary use case, using SourceHook outside of MM:S is also meant to be a supported scenario, and has been used in the past (although there may not be any current, external consumers). The SourceHook tests also rely on this.
Rather than explicitly rely on
mm_LogMessagefor printing the debug messages, this changes the default to just useprintf, with MM:S explicitly overriding it. Also, tests are now temporarily disabled on Linux x64 for now, due to known, expected failures.