Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code highlighting in README table #27

Merged
merged 2 commits into from
Jan 15, 2024
Merged

add code highlighting in README table #27

merged 2 commits into from
Jan 15, 2024

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Jan 7, 2024

  • Add lang="kotlin" to <pre> blocks
  • replace <br/> with HTML escape char for newlines.

Rendered preview

image

Motivation: I find it a little difficult to read unhighlighted code blocks and adding the highlighting helps me to understand the snippets because they more closely resemble what I see in my IDE.

TBH the table structure is a bit messy - I think it might be easier to instead write a HTML table and write the code blocks in Markdown, e.g. https://stackoverflow.com/a/60502719/4161471

add `lang="kotlin"` and replace `<br/>` with HTML escape char for newlines.
@alllex
Copy link
Owner

alllex commented Jan 15, 2024

Thanks for improving this!

The syntax with HTML tables and markdown solutions looks great. I didn't know this was possible.

I'll try incorporating that later. Or, if you feel like doing it, the change is welcome 👍

@alllex alllex merged commit 687f6bf into alllex:main Jan 15, 2024
3 checks passed
@aSemy aSemy deleted the patch-1 branch January 15, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants