feat: implement Allocation extension on strategies #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xAustrian
commented
Sep 4, 2024
| /// @notice Cooldown time from allocationEndTime after which the pool manager is allowed to withdraw tokens. | ||
| uint64 public withdrawalCooldown; | ||
| /// @notice amount to be distributed. It is set during the first distribute() call and stays fixed. | ||
| uint256 public totalPayoutAmount; | ||
|
|
||
| /// @notice token -> bool | ||
| address public allocationToken; |
There was a problem hiding this comment.
Because of this removal I had to make some modifications on _allocate and _distribute
Comment on lines
-9
to
+15
| error ALLOCATION_HAS_STARTED(); | ||
| error ALLOCATION_HAS_ALREADY_STARTED(); | ||
|
|
||
| /// @dev Error thrown when trying to call the function when the allocation is not active | ||
| error ALLOCATION_NOT_ACTIVE(); | ||
| error ALLOCATION_IS_NOT_ACTIVE(); | ||
|
|
||
| /// @dev Error thrown when trying to call the function when the allocation has ended | ||
| error ALLOCATION_NOT_ENDED(); | ||
| error ALLOCATION_IS_NOT_ENDED(); |
There was a problem hiding this comment.
I had to make this little change in order to prevent colliding with the same errors in Errors.sol, maybe we should think about deprecating that library in a future PR
0xOneTony
reviewed
Sep 4, 2024
contracts/strategies/examples/donation-voting/DonationVotingOffchain.sol
Outdated
Show resolved
Hide resolved
contracts/strategies/examples/donation-voting/DonationVotingOnchain.sol
Outdated
Show resolved
Hide resolved
0xAustrian
changed the base branch from
feat/allocators-allowlist-extension
to
v2.1
ilpepepig
reviewed
Sep 8, 2024
contracts/strategies/examples/donation-voting/DonationVotingOnchain.sol
Outdated
Show resolved
Hide resolved
ilpepepig
approved these changes
Sep 8, 2024
thelostone-mc
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes DTT-297