feat: implement sign_transaction on Trezor #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/trezor-signtx
branch
from
99207f7 to
63b00a9
Compare
DaniPopes
force-pushed
the
dani/trezor-signtx
branch
from
619bc9a to
cfeefc2
Compare
gakonst
approved these changes
Jan 6, 2024
Comment on lines
+189
to
+193
| // TODO: Uncomment in 1.76 | ||
| /* | ||
| let signature = if let Some(tx) = (tx as &dyn std::any::Any).downcast_ref::<TxEip1559>() { | ||
| */ | ||
| let signature = if let Some(tx) = tx.__downcast_ref::<TxEip1559>() { |
Comment on lines
+10
to
+17
| /// A signable transaction. | ||
| pub type SignableTx = dyn Transaction<Signature = Signature>; | ||
|
|
||
| /// Extension trait for utilities for signable transactions. | ||
| /// | ||
| /// This trait allows us to generically sign transactions without knowing the | ||
| /// receipt type, and is blanket implemented for transactions which our signer | ||
| /// trait can produce signatures for. | ||
| pub trait SignableTx: Send + Sync + 'static { | ||
| /// This trait is implemented for all types that implement [`Transaction`] with [`Signature`] as the | ||
| /// signature associated type. | ||
| pub trait TransactionExt: Transaction<Signature = Signature> { |
Comment on lines
-17
to
-19
| /// The receipt type for this transaction. | ||
| type Receipt: Receipt; | ||
|
|
There was a problem hiding this comment.
we'll bring this back per Prestwich thinking right? in that case let's leave this commented out instead of removing
There was a problem hiding this comment.
I don't know honestly, should receipts be tied to a specific transaction? Keeping this will make it impossible to have signers use dyn transaction because know that also has to be specified
|
|
||
| mod signed; | ||
| pub use signed::Signed; | ||
|
|
||
| /// Represents a minimal EVM transaction. | ||
| pub trait Transaction: Encodable + Decodable + Send + Sync + 'static { | ||
| pub trait Transaction: std::any::Any + Encodable + Send + Sync + 'static { |
There was a problem hiding this comment.
bleh do we need to explicitly declare the Any here? I guess it'll be always there for most types we impl transaction for, would add a note in the code on why it's needed
DaniPopes
added a commit
that referenced
this pull request
Jan 10, 2024
* refactor: signature keeps v r s in mem wip: port ser tests feature: Parity::chain_id test: normalize 27/28 fix: properly normalize in recovery fix: serde works now refactor wip: lots of stuff refactor: push signature into core primitives feat: seal feat: seal fix: k256 feature in network feature: rlp for TxLegacy feature: block wip test fix: payload lenght feat: sealable feature: Tx types tests: they pass???? refactor: envelope module refactor: TxType refactor: simpler rlp enc/decode for envelope fix: todo feature: enable sign_transaction feat: some froms and some cleanup lint: clippy fix: test feature fix: network receipt bounds receipt.rs restore providers * fix: network * fix: misc fixes for new signature methods * feature: custom 2718 error * fix: transaction may not be RLP * remove log mod * feature: Header, constants, and pure calculations * refactor: impl Sealable * refactor: move 2718 and add docs * chore: enable lints * fix: const fns * fix: correct eip2718 network encoding behavior * feature: arbitrary * cleanup: deps and patch * feature: Receipt trait * fix: impl bloom_cheap * feature: generic signature * doc: document signature type * fix: remove encodable bound * refactor: signabletx trait * fix: some lints and such * fix: remove dbg * fix: spacing * feature: alloy-eips * chore: port access list * misc arbitrary cleanup * fix: encode_2718 length * fix: use core git main instead of local * chore: clippy, docs * fix: features * fix: cap arbitrary logs * chore: use Vec instead of BufMut where possible * feat: fix Signer EIP-155, implement sign_transaction * chore: make ledger internal sign tx public * chore: remove eip1559 duplicate functions * feat: implement sign_transaction on Trezor (#100) * feat: implement sign_transaction on Trezor * fix: dyn trait upcasting is not stable yet * chore: relax requirements * chore: address review --------- Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Merge onto #83
Solution
PR Checklist