fix(admin): id in NodeInfo is string instead of B256 #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsvisa <delweng@gmail.com>
jsvisa
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
Signed-off-by: jsvisa <delweng@gmail.com>
DaniPopes
requested changes
Jul 11, 2024
mattsse
reviewed
Jul 11, 2024
Signed-off-by: jsvisa <delweng@gmail.com>
mattsse
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
lgtm
ty
@DaniPopes if we release alloy with this fix alloy as a patch, this will break 1.0.1 reth build for some folks
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* fix(admin): id in NodeInfo is string instead of B256 Signed-off-by: jsvisa <delweng@gmail.com> * fix testcase Signed-off-by: jsvisa <delweng@gmail.com> * apply code review Signed-off-by: jsvisa <delweng@gmail.com> --------- Signed-off-by: jsvisa <delweng@gmail.com>
j75689
pushed a commit
to bnb-chain/alloy
that referenced
this pull request
Aug 1, 2024
* fix(admin): id in NodeInfo is string instead of B256 Signed-off-by: jsvisa <delweng@gmail.com> * fix testcase Signed-off-by: jsvisa <delweng@gmail.com> * apply code review Signed-off-by: jsvisa <delweng@gmail.com> --------- Signed-off-by: jsvisa <delweng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Return the same response type as geth's, ref https://github.com/ethereum/go-ethereum/blob/v1.14.0/p2p/server.go#L1078-L1079
Solution
PR Checklist