Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add authorization list to rpc transaction and tx receipt types #1051

Conversation

PanGan21
Copy link
Contributor

@PanGan21 PanGan21 commented Jul 14, 2024

Motivation

Adds 7702 authorization list to rpc transaction and transaction receipt types.
Related: #1032

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

crates/rpc-types-eth/src/transaction/mod.rs Outdated Show resolved Hide resolved
crates/rpc-types-eth/src/transaction/receipt.rs Outdated Show resolved Hide resolved
/// The authorization list is a list of tuples that store the address to code which the signer
/// desires to execute in the context of their EOA.
#[serde(skip_serializing_if = "Option::is_none")]
pub authorization_list: Option<Vec<Authorization>>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we actually want the SignedAuthoriazion here because we also need the signature

Copy link
Contributor Author

@PanGan21 PanGan21 Jul 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Some pipelines are failing so I will probably need to enable a feature

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fixed!

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@PanGan21 PanGan21 requested a review from mattsse July 15, 2024 09:43
@mattsse mattsse merged commit 7d618ee into alloy-rs:main Jul 15, 2024
22 checks passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
…lloy-rs#1051)

* feat: add authorization list to rpc transaction and tx receipt types

* fix: add default impl

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

* fix: use signed authorization for rpc transaction type

* fix: enable arbitrary and k256 features for development

* fix: cargo hack fix

* chore: flatten signature

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
j75689 pushed a commit to bnb-chain/alloy that referenced this pull request Aug 1, 2024
…lloy-rs#1051)

* feat: add authorization list to rpc transaction and tx receipt types

* fix: add default impl

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

* fix: use signed authorization for rpc transaction type

* fix: enable arbitrary and k256 features for development

* fix: cargo hack fix

* chore: flatten signature

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants