fix(provider): Prevent panic from having 0 keys when calling on_anvil_with_wallet_and_config
#1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moricho
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
mattsse
requested changes
Jul 15, 2024
crates/provider/src/builder.rs
Outdated
Comment on lines
422
to
425
| pub fn on_anvil_with_wallet_and_config( | ||
| self, | ||
| f: impl FnOnce(alloy_node_bindings::Anvil) -> alloy_node_bindings::Anvil, | ||
| ) -> <JoinFill<F, WalletFiller<alloy_network::EthereumWallet>> as ProviderLayer< | ||
| L::Provider, | ||
| alloy_transport_http::Http<reqwest::Client>, | ||
| >>::Provider | ||
| ) -> Result< |
There was a problem hiding this comment.
I'd like to keep this function and not return a result, but we can add fn try_on_anvil... for this and on_anvil calls this and unwraps
moricho
commented
Jul 15, 2024
Comment on lines
+349
to
+352
| type JoinedEthereumWalletFiller<F> = JoinFill<F, WalletFiller<alloy_network::EthereumWallet>>; | ||
|
|
||
| #[cfg(any(test, feature = "anvil-node"))] | ||
| type AnvilProviderResult<T> = Result<T, alloy_node_bindings::anvil::AnvilError>; |
There was a problem hiding this comment.
Added these type aliases to avoid clippy error
There was a problem hiding this comment.
@mattsse By the way, should we create a type alias for Http<reqwest::Client>? It appears so many times in this repository and it can cause clippy warnings very complex type used. Consider factoring parts into type definitions when a type is complex, as in this case.
mattsse
approved these changes
Jul 16, 2024
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
…l_with_wallet_and_config` (alloy-rs#1055) * node-bindings: Add AnvilError::NoKeysAvailable * prevent panic from having 0 keys * fix the error handlings for `on_anvil_with_wallet` * fix clippy * fix(clippy): Add type alias * Add `try_on_anvil_with_wallet_and_config` and call it in `on_anvil_with_wallet_and_config` * Revert test changes * Fix docs
j75689
pushed a commit
to bnb-chain/alloy
that referenced
this pull request
Aug 1, 2024
…l_with_wallet_and_config` (alloy-rs#1055) * node-bindings: Add AnvilError::NoKeysAvailable * prevent panic from having 0 keys * fix the error handlings for `on_anvil_with_wallet` * fix clippy * fix(clippy): Add type alias * Add `try_on_anvil_with_wallet_and_config` and call it in `on_anvil_with_wallet_and_config` * Revert test changes * Fix docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #889.
on_anvil_with_wallet_and_configcan panic if the available key in an anvil instance is 0.Solution
Adds the new error
NoKeysAvailabletoAnvilErrorinalloy-node-bindingsand uses it as the error ofon_anvil_with_wallet_and_configPR Checklist