-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refac: rm 2930 and 7702 - use alloy-rs/eips #1181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
August 23, 2024 06:56
mattsse
requested changes
Aug 24, 2024
onbjerg
reviewed
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's update the alloy eips readme to point to the new repo so people know where to look for the code
onbjerg
approved these changes
Aug 26, 2024
Bumping |
yash-atreya
added
the
blocked
This cannot move forward until something else changes
label
Aug 27, 2024
yash-atreya
removed
the
blocked
This cannot move forward until something else changes
label
Aug 27, 2024
mattsse
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ref #1174.
Solution
2930 and 7702 have been extracted to a new repo - https://github.com/alloy-rs/eips. Use that and re-export in alloy-eips.
PR Checklist