Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move reth genesis to alloy-genesis #120

Merged
merged 9 commits into from
Jan 18, 2024

Conversation

supernovahs
Copy link
Contributor

@supernovahs supernovahs marked this pull request as ready for review January 18, 2024 12:17
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

a few more nits, then this is good

crates/genesis/src/genesis.rs Outdated Show resolved Hide resolved
crates/genesis/src/lib.rs Outdated Show resolved Hide resolved
crates/genesis/src/account.rs Outdated Show resolved Hide resolved
crates/genesis/src/genesis.rs Outdated Show resolved Hide resolved
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, as next step we can also replace the genesis types in

https://github.com/alloy-rs/alloy/blob/main/crates/node-bindings/src/genesis.rs

with this one

@mattsse mattsse merged commit 92b04d1 into alloy-rs:main Jan 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract Genesis types to standalone crate in alloy
2 participants