feat(provider): subscribe to new blocks if possible in heartbeat #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
DaniPopes
force-pushed
the
dani/heartbeat-subscription
branch
from
76f55a9 to
a18a111
Compare
DaniPopes
commented
Sep 20, 2024
DaniPopes
commented
Sep 20, 2024
crates/rpc-client/src/poller.rs
Outdated
There was a problem hiding this comment.
Best reviewed with "hide whitespace"; this is just moving async move to async fn
DaniPopes
force-pushed
the
dani/heartbeat-subscription
branch
from
664e194 to
06cca3a
Compare
3 tasks
lwedge99
pushed a commit
to sentioxyz/alloy
that referenced
this pull request
Oct 8, 2024
…oy-rs#1321) * feat(provider): subscribe to new blocks if possible in heartbeat * msg * wasm * fix * move into stream * feat: lazily subscribe to newHeads * chore: remove async from get_heart * testname
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1318