-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(consensus
): populate chain id when decoding signed legacy txs
#137
Conversation
consensus
): populate chain id for legacy txs when decoding signed legacy txsconsensus
): populate chain id when decoding signed legacy txs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused why TxLegacy is also Encodeable and Decodeable,
this can be misused easily, because that's most likely never what you want?
re signature and eip155:
@mattsse agreed it feels a bit odd to have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last nit
Motivation
The chain id was not being populated when decoding a signed legacy tx, leading to decoding issues.
Closes #125
Solution
Populate the chain id param when decoding.
PR Checklist